You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/17 12:50:00 UTC
[jira] [Commented] (ARTEMIS-1293) Log messages without prefixed id
code in artemis-commons
[ https://issues.apache.org/jira/browse/ARTEMIS-1293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089778#comment-16089778 ]
ASF GitHub Bot commented on ARTEMIS-1293:
-----------------------------------------
GitHub user treblereel opened a pull request:
https://github.com/apache/activemq-artemis/pull/1402
[ARTEMIS-1293] Log messages without prefixed id code in artemis-commons
JIRA : https://issues.apache.org/jira/browse/ARTEMIS-1293
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/treblereel/activemq-artemis-wildfly IMPROVE_LOGGING_ARTEMIS_COMMONS
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1402
----
commit 54f358ae1d8fffa357d1368617589b161339e8f4
Author: Dmitrii Tikhomirov <dt...@redhat.com>
Date: 2017-07-17T12:38:08Z
[ARTEMIS-1293] Log messages without prefixed id code in artemis-commons
----
> Log messages without prefixed id code in artemis-commons
> --------------------------------------------------------
>
> Key: ARTEMIS-1293
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1293
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.1.0
> Reporter: Dmitrii Tikhomirov
> Priority: Minor
> Fix For: 2.2.0
>
>
> Run following command in artemis-commons directory
> {code}
> [treblereel@dhcp-10-40-4-236 artemis-commons]$ find -name "*.java" | grep -i -E -v "test|example|junit" | xargs grep -i -E "LOG(GER)*\.error\(|LOG(GER)*\.warn\(|LOG(GER)*\.info\("
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn(e.getMessage(), e);
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn(e.getMessage(), e);
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn(e.getMessage(), e);
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn("Ping Address " + address + " wasn't reacheable");
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn("Ping url " + url + " wasn't reacheable");
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.info("Network is healthy, starting service " + component);
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn("Error starting component " + component, e);
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.info("Network is unhealthy, stopping service " + component);
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn("Error stopping component " + component, e);
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn(e.getMessage(), e);
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn(inputLine);
> ./src/main/java/org/apache/activemq/artemis/core/server/NetworkHealthCheck.java: logger.warn(e.getMessage(), e);
> ./src/main/java/org/apache/activemq/artemis/utils/ByteUtil.java: logger.warn(e.getMessage(), e);
> ./src/main/java/org/apache/activemq/artemis/utils/FileUtil.java: logger.warn("Could not list files to clean up in: " + directory.getAbsolutePath());
> ./src/main/java/org/apache/activemq/artemis/utils/FileUtil.java: logger.warn("Failed to clean up file: " + f.getAbsolutePath());
> ./src/main/java/org/apache/activemq/artemis/utils/Base64.java: logger.warn("Object cannot be serialized", e.getMessage(), e);
> ./src/main/java/org/apache/activemq/artemis/utils/Base64.java: logger.warn("Unable to encode byte array into Base64 notation", e.getMessage(), e);
> ./src/main/java/org/apache/activemq/artemis/utils/Base64.java: logger.warn("Unable to deserialize object", e.getMessage(), e);
> ./src/main/java/org/apache/activemq/artemis/utils/actors/OrderedExecutor.java: logger.warn(t.getMessage(), t);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)