You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/14 13:35:38 UTC
[GitHub] [flink] AHeise opened a new pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
AHeise opened a new pull request #13383:
URL: https://github.com/apache/flink/pull/13383
(Unchanged backport of https://github.com/apache/flink/pull/13000)
## What is the purpose of the change
Wait for the LegacySourceFunctionThread to finish when cancelling the task.
This prevents premature freeing of resources, particularly LibraryCache (see [FLINK-15467](https://issues.apache.org/jira/browse/FLINK-15467) discussion).
Implemented by waiting in `SourceStreamTask.invoke()` for the `sourceThread` to complete.
There were several existing tests failures (listed below) which were fixed by completing the future if thread isn't alive; or by returning a completed future if a task is failing.
## Verifying this change
* Added unit test: `SourceStreamTaskTest.testWaitsForSourceThreadOnCancel`
* Tested manually on a local cluster
* Existing tests covering different scenarios of task exit and cancellation: `InterruptSensitiveRestoreTest`, `StreamTaskTest.testEarlyCanceling`, `FastFailuresITCase`
## Does this pull request potentially affect one of the following parts:
* Dependencies (does it add or upgrade a dependency): no
* The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
* The serializers: no
* The runtime per-record code paths (performance sensitive): no
* Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
* The S3 file system connector: no
## Documentation
* Does this pull request introduce a new feature? no
* If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692531110
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692914561
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692259158
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #13383:
URL: https://github.com/apache/flink/pull/13383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692531110",
"triggerType" : "MANUAL"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"triggerType" : "PUSH"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692914561",
"triggerType" : "MANUAL"
}, {
"hash" : "24cc97f41f12665cf71ce8dbe3fb92c9ea2e970a",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184672832",
"triggerID" : "24cc97f41f12665cf71ce8dbe3fb92c9ea2e970a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
* 708c30a954d9bdc58bd15c3b198970cdcd989d72 UNKNOWN
* 24cc97f41f12665cf71ce8dbe3fb92c9ea2e970a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/184672832)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692531110",
"triggerType" : "MANUAL"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
* 708c30a954d9bdc58bd15c3b198970cdcd989d72 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692531110",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-693197752
Travis on Flink CI doesn't like to pick up the right commit.
On my private travis, there were a few timeouts, but it looks green to me ;) https://travis-ci.org/github/AHeise/flink/builds/727356614
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692531110",
"triggerType" : "MANUAL"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"triggerType" : "PUSH"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692914561",
"triggerType" : "MANUAL"
}, {
"hash" : "24cc97f41f12665cf71ce8dbe3fb92c9ea2e970a",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184672832",
"triggerID" : "24cc97f41f12665cf71ce8dbe3fb92c9ea2e970a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
* 708c30a954d9bdc58bd15c3b198970cdcd989d72 UNKNOWN
* 24cc97f41f12665cf71ce8dbe3fb92c9ea2e970a Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/184672832)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692058712
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fff940ad81b3d3416dea16f0d05db56786b34cc7 (Mon Sep 14 13:38:31 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15467).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692531110",
"triggerType" : "MANUAL"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"triggerType" : "PUSH"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692914561",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
* 708c30a954d9bdc58bd15c3b198970cdcd989d72 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692531110",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692531110",
"triggerType" : "MANUAL"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"triggerType" : "PUSH"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
* 708c30a954d9bdc58bd15c3b198970cdcd989d72 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692531110",
"triggerType" : "MANUAL"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"triggerType" : "PUSH"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692914561",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
* 708c30a954d9bdc58bd15c3b198970cdcd989d72 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692759980
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13383: [FLINK-15467][task] Wait for sourceTaskThread to finish before exiting from StreamTask.invoke [1.10]
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13383:
URL: https://github.com/apache/flink/pull/13383#issuecomment-692066644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"triggerType" : "PUSH"
}, {
"hash" : "cc178a714fc8d6637418e81efae55231a5c08cc1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692259158",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692531110",
"triggerType" : "MANUAL"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"triggerType" : "PUSH"
}, {
"hash" : "708c30a954d9bdc58bd15c3b198970cdcd989d72",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692759980",
"triggerType" : "MANUAL"
}, {
"hash" : "75eb7195c13f8641a58870c1ae2861c1302e437c",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/184220187",
"triggerID" : "692914561",
"triggerType" : "MANUAL"
}, {
"hash" : "24cc97f41f12665cf71ce8dbe3fb92c9ea2e970a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "24cc97f41f12665cf71ce8dbe3fb92c9ea2e970a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 75eb7195c13f8641a58870c1ae2861c1302e437c Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/184220187)
* cc178a714fc8d6637418e81efae55231a5c08cc1 UNKNOWN
* 708c30a954d9bdc58bd15c3b198970cdcd989d72 UNKNOWN
* 24cc97f41f12665cf71ce8dbe3fb92c9ea2e970a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org