You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2016/01/03 12:28:30 UTC

[GitHub] cloudstack pull request: Quota: findbug fixes

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1289#issuecomment-168489999
  
    Ping @bhaisaab @agneya2001 the quota plugin unit tests are failing in `4.7` and `master` branches:
    
    ```
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD FAILURE
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 02:44 min (Wall Clock)
    [INFO] Finished at: 2016-01-03T09:51:53+01:00
    [INFO] Final Memory: 78M/1371M
    [INFO] ------------------------------------------------------------------------
    [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on project cloud-framework-quota: There are test failures.
    [ERROR] 
    ```
    
    Due to:
    ```
    Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.054 sec
    <<< FAILURE! - in org.apache.cloudstack.quota.QuotaStatementTest
    
    testSendStatement(org.apache.cloudstack.quota.QuotaStatementTest)  Time
    elapsed: 0.011 sec  <<< FAILURE!
    
    org.mockito.exceptions.verification.WantedButNotInvoked:
    
    Wanted but not invoked:
    
    alertManager.sendQuotaAlert(
    
    
    org.apache.cloudstack.quota.QuotaAlertManagerImpl$DeferredQuotaEmail@6e9d6ff7
    
    );
    
    -> at
    org.apache.cloudstack.quota.QuotaStatementTest.testSendStatement(QuotaStatementTest.java:251)
    
    Actually, there were zero interactions with this mock.
    
    
    at
    org.apache.cloudstack.quota.QuotaStatementTest.testSendStatement(QuotaStatementTest.java:251)
    
    
    
    Results :
    
    
    Failed tests:
    
      QuotaStatementTest.testSendStatement:251
    
    Wanted but not invoked:
    
    alertManager.sendQuotaAlert(
    
    
    org.apache.cloudstack.quota.QuotaAlertManagerImpl$DeferredQuotaEmail@6e9d6ff7
    
    );
    
    -> at
    org.apache.cloudstack.quota.QuotaStatementTest.testSendStatement(QuotaStatementTest.java:251)
    ```
    
    Please fix against `4.7` branch after which we will forward merge to `master`. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---