[GitHub] vikasprabhakar commented on issue #453: Split into declaration and assignment issue for var type

[GitBox <gi...@apache.org>]

vikasprabhakar commented on issue #453: Split into declaration and assignment issue for var type
URL: https://github.com/apache/incubator-netbeans/pull/453#issuecomment-373309043
 
 
   Added rtaneja1 review comment as:
   1 Are there any other .Kind for which control comes here?
   --> Remove the kind check
   2 Why startsWith check? Can we check for equals here.
   --> Can't use code.equals("var "), because code has full statement as String.
   3 If we are using any constant strings, we should add a line comment //NOI18N to skip flagging by nls audit tool.
   --> Implemented

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists