You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/04/13 03:27:44 UTC

[GitHub] [james-project] Arsnael commented on pull request #385: [WIP] JAMES-3520 MDN/send

Arsnael commented on pull request #385:
URL: https://github.com/apache/james-project/pull/385#issuecomment-818403957


   Did you run your tests locally? Bunch of errors, that seem easy to fix. For example:
   ```
   org.opentest4j.AssertionFailedError: 
   
   expected: "Reporting-UA: UA_name; UA_product
   MDN-Gateway: postal;5 rue Charles mercier
   Original-Recipient: rfc822; originalRecipient
   Final-Recipient: rfc822; final_recipient
   Original-Message-ID: original_message_id
   Disposition: automatic-action/MDN-sent-automatically;processed/error,failed
   "
   but was : "Reporting-UA: UA_name; UA_product
   MDN-Gateway: postal; 5 rue Charles mercier
   Original-Recipient: rfc822; originalRecipient
   Final-Recipient: rfc822; final_recipient
   Original-Message-ID: original_message_id
   Disposition: automatic-action/MDN-sent-automatically;processed/error,failed
   "
   	at org.apache.james.mdn.MDNReportFormattingTest.generateMDNReportShouldFormatGatewayWithExoticNameType(MDNReportFormattingTest.java:408)
   ```
   
   It seems you miss a space in `MDN-Gateway: postal;5 rue Charles mercier`, after `portal;`... You have similar issues in other mdn tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org