You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/07 17:16:18 UTC
[GitHub] [arrow] lidavidm opened a new pull request #10267: ARROW-12686: [C++][FlightRPC] Convert Flight reader into a regular reader
lidavidm opened a new pull request #10267:
URL: https://github.com/apache/arrow/pull/10267
This provides compatibility with APIs that expect regular RecordBatchReaders, e.g. exporting via the C Data Interface. The Flight interface itself cannot implement RecordBatchReader because getting the schema is not an infallible operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #10267: ARROW-12686: [C++][Python][FlightRPC] Convert Flight reader into a regular reader
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #10267:
URL: https://github.com/apache/arrow/pull/10267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on a change in pull request #10267: ARROW-12686: [C++][Python][FlightRPC] Convert Flight reader into a regular reader
Posted by GitBox <gi...@apache.org>.
westonpace commented on a change in pull request #10267:
URL: https://github.com/apache/arrow/pull/10267#discussion_r630577865
##########
File path: python/pyarrow/_flight.pyx
##########
@@ -874,6 +874,13 @@ cdef class _MetadataRecordBatchReader(_Weakrefable, _ReadPandasMixin):
return chunk
+ def to_reader(self):
+ """Convert this reader into a regular RecordBatchReader."""
Review comment:
Nit: Perhaps add a note that it does this by first reading the schema or some kind of indication that calling `to_reader` will cause it to read the schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10267: ARROW-12686: [C++][FlightRPC] Convert Flight reader into a regular reader
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10267:
URL: https://github.com/apache/arrow/pull/10267#issuecomment-834633129
https://issues.apache.org/jira/browse/ARROW-12686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org