You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jerryshao <gi...@git.apache.org> on 2016/04/18 07:49:18 UTC

[GitHub] spark pull request: [SPARK-14453]Remove the support of SPARK_JAVA_...

GitHub user jerryshao opened a pull request:

    https://github.com/apache/spark/pull/12465

    [SPARK-14453]Remove the support of SPARK_JAVA_OPTS env variable

    ## What changes were proposed in this pull request?
    
    `SPARK_JAVA_OPTS` is deprecated since Spark 1.0, it is recommended to use `SparkConf` rather than env variable, so here propose to remove this variable.
    
    ## How was this patch tested?
    
    Unit test.
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jerryshao/apache-spark SPARK-14453

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12465.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12465
    
----
commit dd6e3ca465adeec5a8ae8dcb858311b49614bc0f
Author: jerryshao <ss...@hortonworks.com>
Date:   2016-04-18T05:28:11Z

    Remove SPARK_JAVA_OPTS env variable

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-14453]Remove the support of SPARK_JAVA_...

Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao commented on the pull request:

    https://github.com/apache/spark/pull/12465#issuecomment-211265225
  
    Thanks @srowen for your comments. Let me see if I can also clean other obsolete env variables.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-14453]Remove the support of SPARK_JAVA_...

Posted by jerryshao <gi...@git.apache.org>.
Github user jerryshao closed the pull request at:

    https://github.com/apache/spark/pull/12465


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-14453]Remove the support of SPARK_JAVA_...

Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/12465#issuecomment-211260939
  
    I think that's right, if that's all the occurrences of SPARK_JAVA_OPTS. When I looked at this I realized there were other OPTS variables too, and generally, lots of env variables to get rid of. Removing one might be fine but I wonder if there's a bigger logical group to remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org