You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/10/19 18:45:46 UTC
[GitHub] [incubator-nuttx] oreh-a opened a new pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
oreh-a opened a new pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704
## Summary
stm32f0/g0/l0 chips rcc files have ifdef/endif ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG sections for supporting board's clock configuration function, but it is not supported by related Kconfig file. Looks like it was copy-pasted from stm32 drivers implementation but was not finished. PR renames this option to ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG and adds needed configuration lines to Kconfig
## Impact
No impact by default
## Testing
Select stm32f0/g0/l0 families chip, enable "Custom clock configuration" option, build the project. Now board's provided stm32_board_clockconfig function should be used instead of stm32_stdclockconfig()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704#discussion_r732870737
##########
File path: arch/arm/src/stm32f0l0g0/stm32_rcc.c
##########
@@ -161,7 +161,7 @@ void stm32_clockconfig(void)
rcc_resetbkp();
-#if defined(CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG)
+#if defined(CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG)
Review comment:
But, I don't see the defconfig switch to new Kconfig.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] oreh-a commented on a change in pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
oreh-a commented on a change in pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704#discussion_r732482726
##########
File path: arch/arm/src/stm32f0l0g0/stm32_rcc.c
##########
@@ -161,7 +161,7 @@ void stm32_clockconfig(void)
rcc_resetbkp();
-#if defined(CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG)
+#if defined(CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG)
Review comment:
Naming consistency: stm32f0g0l0/Kconfig doesn't contain CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG, it needs to be added and all options in stm32f0g0l0/Kconfig are named with _STM32F0G0L0_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704#discussion_r732890707
##########
File path: arch/arm/src/stm32f0l0g0/stm32_rcc.c
##########
@@ -161,7 +161,7 @@ void stm32_clockconfig(void)
rcc_resetbkp();
-#if defined(CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG)
+#if defined(CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG)
Review comment:
But should we have the follow up PR to enable the new config in some defconfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] oreh-a commented on a change in pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
oreh-a commented on a change in pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704#discussion_r734363501
##########
File path: arch/arm/src/stm32f0l0g0/stm32_rcc.c
##########
@@ -161,7 +161,7 @@ void stm32_clockconfig(void)
rcc_resetbkp();
-#if defined(CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG)
+#if defined(CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG)
Review comment:
I've rechecked, no one board inside boards/arm/stm32f0g0l0 has custom_clock set (nor in defconfig nor in source file)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704#discussion_r732390109
##########
File path: arch/arm/src/stm32f0l0g0/stm32_rcc.c
##########
@@ -161,7 +161,7 @@ void stm32_clockconfig(void)
rcc_resetbkp();
-#if defined(CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG)
+#if defined(CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG)
Review comment:
what's real difference between CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG and CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] oreh-a commented on a change in pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
oreh-a commented on a change in pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704#discussion_r732889196
##########
File path: arch/arm/src/stm32f0l0g0/stm32_rcc.c
##########
@@ -161,7 +161,7 @@ void stm32_clockconfig(void)
rcc_resetbkp();
-#if defined(CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG)
+#if defined(CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG)
Review comment:
Adding 'config' to Kconfig is a part of this PR. Isn't it enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] oreh-a commented on a change in pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
oreh-a commented on a change in pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704#discussion_r732895381
##########
File path: arch/arm/src/stm32f0l0g0/stm32_rcc.c
##########
@@ -161,7 +161,7 @@ void stm32_clockconfig(void)
rcc_resetbkp();
-#if defined(CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG)
+#if defined(CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG)
Review comment:
But i'll recheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704#discussion_r733296935
##########
File path: arch/arm/src/stm32f0l0g0/stm32_rcc.c
##########
@@ -161,7 +161,7 @@ void stm32_clockconfig(void)
rcc_resetbkp();
-#if defined(CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG)
+#if defined(CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG)
Review comment:
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] oreh-a commented on a change in pull request #4704: Add custom clock config option to stm32f0/g0/l0 chips
Posted by GitBox <gi...@apache.org>.
oreh-a commented on a change in pull request #4704:
URL: https://github.com/apache/incubator-nuttx/pull/4704#discussion_r732894624
##########
File path: arch/arm/src/stm32f0l0g0/stm32_rcc.c
##########
@@ -161,7 +161,7 @@ void stm32_clockconfig(void)
rcc_resetbkp();
-#if defined(CONFIG_ARCH_BOARD_STM32_CUSTOM_CLOCKCONFIG)
+#if defined(CONFIG_ARCH_BOARD_STM32F0G0L0_CUSTOM_CLOCKCONFIG)
Review comment:
How can it be present in defconfig (boards?) if Kconfig didn't have it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org