You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2023/02/13 12:47:17 UTC
[GitHub] [arrow-site] AlenkaF opened a new pull request, #312: Update how versionwarning.js handles doc versions with more than one digit
AlenkaF opened a new pull request, #312:
URL: https://github.com/apache/arrow-site/pull/312
This PR corrects the check for version number of the documentation when adding version warnings to the html files.
See: https://github.com/apache/arrow/issues/34023
Also, additional copying of the versionwarning.js file seems to happen with the release. Currently there are three versions of the same document:
- docs/_static/versionwarning.js
- docs/dev/_static/versionwarning.js
- docs/10.0/_static/versionwarning.js
Second and third should be redundant and are removed with this PR. I will create a separate issue on the apache/arrow repo to research and correct how the versionwarning.js file is being copied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] jorisvandenbossche merged pull request #312: Update how versionwarning.js handles doc versions with more than one digit
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #312:
URL: https://github.com/apache/arrow-site/pull/312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] kou commented on a diff in pull request #312: Update how versionwarning.js handles doc versions with more than one digit
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #312:
URL: https://github.com/apache/arrow-site/pull/312#discussion_r1105024872
##########
docs/_static/versionwarning.js:
##########
@@ -30,6 +30,7 @@
// Path of the page
var location_array = location.pathname.split('/');
var versionPath = location_array[2];
+ var versionNumber = Number (versionPath.match(/^\d+/))
Review Comment:
```suggestion
var versionNumber = Number(versionPath.match(/^\d+/))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] AlenkaF commented on pull request #312: Update how versionwarning.js handles doc versions with more than one digit
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #312:
URL: https://github.com/apache/arrow-site/pull/312#issuecomment-1427904360
The issue about multiple copies of `versionwarning.js` in `apache/arrow-site`: https://github.com/apache/arrow/issues/34160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-site] AlenkaF commented on pull request #312: Update how versionwarning.js handles doc versions with more than one digit
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #312:
URL: https://github.com/apache/arrow-site/pull/312#issuecomment-1429130263
> I think that the upstream of `versionwarning.js` is https://github.com/apache/arrow/blob/master/docs/source/_static/versionwarning.js . Why do we update `versionwarning.js` in apache/arrow-site instead of apache/arrow? I think that this change will be overwritten in the next release.
Correct, I plan to update the file in the main repo as a part of https://github.com/apache/arrow/issues/34023. But first I would like to correct the current state on the arrow site, if possible. Plus, the multiple versions of the .js file bothers me also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org