[jira] [Commented] (AVRO-4219) [Build][Java] Apache RAT plugin is run when -PskipQuality is set

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-4219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18043654#comment-18043654 ] 

ASF subversion and git services commented on AVRO-4219:
-------------------------------------------------------

Commit 5fc7e78f64cf585667f29cd276e7d7dc37fbe4c6 in avro's branch refs/heads/main from Ryan Skraba
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=5fc7e78f64 ]

AVRO-4219: Make skipQuality profile top-level (#3590)



> [Build][Java] Apache RAT plugin is run when -PskipQuality is set
> ----------------------------------------------------------------
>
>                 Key: AVRO-4219
>                 URL: https://issues.apache.org/jira/browse/AVRO-4219
>             Project: Apache Avro
>          Issue Type: Task
>          Components: build, java
>    Affects Versions: 1.12.1
>            Reporter: Ryan Skraba
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The RAT plugin is configured at the top-level pom.xml, but the {{skipQuality}} profile is configured in {{lang/java}}.  As a consequence, the rat plugin is run on all workflows that use Java, even when it's unrelated to what is being built or under test (for example [C# interoperability tests|https://github.com/apache/avro/actions/runs/19940449174/job/57176535746#step:8:85]).
> {code}
> [INFO] --- apache-rat:0.16.1:check (default) @ avro-toplevel ---
> [INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 6, approved: 1534 licenses.
> [INFO] 
> {code}
> We should definitely be applying RAT checks at the top-level and to files in the source distribution, but we should not be applying them when {{-PskipQuality}} is explicitly set.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)