You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/19 16:12:44 UTC

[GitHub] [pulsar] AnonHxy opened a new pull request, #15677: [client]Fix exception message when messageRouting is CustomPartition and Mess…

AnonHxy opened a new pull request, #15677:
URL: https://github.com/apache/pulsar/pull/15677

   ### Motivation
   
   
    when `messageRoutingMode` is set `CustomPartition` and `messageRouter` is  not set,  the exception message is :
   ```
   When 'messageRouter' is set, 'messageRoutingMode' should be set as CustomPartition
   ```
   which will confuse the users
   
   ### Modifications
   
   Correct the exceptions message
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
     -  `org.apache.pulsar.client.impl.ProducerBuilderImplTest#testProducerBuilderImplWhenMessageRoutingIsCustomPartitionAndMessageRouterNotSet`
     
   
   
   ### Documentation
     
   - [x] `no-need-doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] gaozhangmin merged pull request #15677: [improve][client] improve exception messages in setMessageRoutingMode

Posted by GitBox <gi...@apache.org>.
gaozhangmin merged PR #15677:
URL: https://github.com/apache/pulsar/pull/15677


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org