You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/12/15 20:28:38 UTC

[Impala-ASF-CR] IMPALA-12633: Remove DCHECK for slow SetQueryInflight

Hello Quanlong Huang, Andrew Sherman, Riza Suminto, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20799

to look at the new patch set (#3).

Change subject: IMPALA-12633: Remove DCHECK for slow SetQueryInflight
......................................................................

IMPALA-12633: Remove DCHECK for slow SetQueryInflight

Removes the DCHECK that the original query is inflight before trying to
close it during a query retry. SetQueryInflight is a separate operation
the server performs after a query has started executing async, and it's
possible for the query to fail and retry before the server calls
SetQueryInflight. When that happens, we still need to perform cleanup
or the original request_state is never closed and we hit a different
DCHECK: "BlockOnWait() needs to be called!"

Adds a debug action and test where just the original query is delayed
during the SetQueryInflight call.

Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7
---
M be/src/runtime/query-driver.cc
M be/src/service/impala-server.cc
M tests/custom_cluster/test_query_retries.py
3 files changed, 47 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/99/20799/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20799
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic17a5e12d9db61cb19306270174518a8dfd281a7
Gerrit-Change-Number: 20799
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>