You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/13 05:54:58 UTC

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6041: [CODEGEN] Fix code generation bugs for C/CUDA & Improve VerifyGPUCode pass

jcf94 commented on a change in pull request #6041:
URL: https://github.com/apache/incubator-tvm/pull/6041#discussion_r453449086



##########
File path: src/target/source/codegen_c.cc
##########
@@ -720,14 +720,15 @@ void CodeGenC::VisitStmt_(const StoreNode* op) {
   } else {
     CHECK(is_one(op->predicate)) << "Predicated store is not supported";
     arith::PVar<PrimExpr> base;
+
+    // The assignment below introduces side-effect, and the resulting value cannot
+    // be reused across multiple expression, thus a new scope is needed

Review comment:
       Great!
   Do we need to add some UTs to cover these cases?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org