You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/08/16 19:16:16 UTC
[GitHub] [flink] AHeise opened a new pull request #16851: [FLINK-23776][streaming] Fix emission of timestamp-less records in Sources.
AHeise opened a new pull request #16851:
URL: https://github.com/apache/flink/pull/16851
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently, timestamp-less records are emitted as records with timestamp NO_TIMESTAMP. That's retriggering metric registration in new Soruces.
## Brief change log
- Fix timestamp handling in new Sources.
## Verifying this change
Adjusted the respective test case to actually test that the record has no timestamp.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
}, {
"hash" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362",
"triggerID" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"triggerType" : "PUSH"
}, {
"hash" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22403",
"triggerID" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"triggerType" : "PUSH"
}, {
"hash" : "2178ac743f87edaf1792db765a0fc0b5b058c66e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2178ac743f87edaf1792db765a0fc0b5b058c66e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11392b6d7107d00ba49f39b8675c4a98ab2cebb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362)
* 0bb725aeff9d4128b2693f15c023d3f9dfff16fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22403)
* 2178ac743f87edaf1792db765a0fc0b5b058c66e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
}, {
"hash" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362",
"triggerID" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"triggerType" : "PUSH"
}, {
"hash" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11392b6d7107d00ba49f39b8675c4a98ab2cebb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362)
* 0bb725aeff9d4128b2693f15c023d3f9dfff16fe UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix emission of timestamp-less records in Sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
}, {
"hash" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327)
* 11392b6d7107d00ba49f39b8675c4a98ab2cebb1 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
}, {
"hash" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362",
"triggerID" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"triggerType" : "PUSH"
}, {
"hash" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22403",
"triggerID" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11392b6d7107d00ba49f39b8675c4a98ab2cebb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362)
* 0bb725aeff9d4128b2693f15c023d3f9dfff16fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22403)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
}, {
"hash" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362",
"triggerID" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"triggerType" : "PUSH"
}, {
"hash" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22403",
"triggerID" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"triggerType" : "PUSH"
}, {
"hash" : "2178ac743f87edaf1792db765a0fc0b5b058c66e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22419",
"triggerID" : "2178ac743f87edaf1792db765a0fc0b5b058c66e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2178ac743f87edaf1792db765a0fc0b5b058c66e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix emission of timestamp-less records in Sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16851: [FLINK-23776][streaming] Fix emission of timestamp-less records in Sources.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899758670
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37 (Mon Aug 16 19:20:33 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix emission of timestamp-less records in Sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
}, {
"hash" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362",
"triggerID" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327)
* 11392b6d7107d00ba49f39b8675c4a98ab2cebb1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
AHeise commented on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-901790288
> Thanks for triaging the performance regression and spotting an actual bug.
> Nit: Do we have a way to verify that this fix resolves the performance regression?
Yes, http://codespeed.dak8s.net:8000/timeline/?ben=mapRebalanceMapSink.F27_UNBOUNDED&env=2 . If you are referring to a unit test, I'm afraid that there is no low-hanging fruit. We could change metric groups to fail on duplicates (instead of warning).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #16851:
URL: https://github.com/apache/flink/pull/16851#discussion_r691197520
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -461,8 +462,9 @@ public MetricTrackingOutput(
public void emitRecord(StreamRecord<OUT> streamRecord) throws Exception {
output.emitRecord(streamRecord);
this.sourceMetricGroup.recordEmitted();
- if (streamRecord.hasTimestamp()) {
- this.sourceMetricGroup.eventTimeEmitted(streamRecord.getTimestamp());
+ long timestamp = streamRecord.getTimestamp();
+ if (timestamp != TimestampAssigner.NO_TIMESTAMP) {
Review comment:
It doesn't make sense to keep the check as `SourceOutputWithWatermarks#collect` will never set the flag.
But I created https://issues.apache.org/jira/browse/FLINK-23858 to clarify it further and potentially deprecate the old uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise merged pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
AHeise merged pull request #16851:
URL: https://github.com/apache/flink/pull/16851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] AHeise commented on a change in pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
AHeise commented on a change in pull request #16851:
URL: https://github.com/apache/flink/pull/16851#discussion_r691197520
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -461,8 +462,9 @@ public MetricTrackingOutput(
public void emitRecord(StreamRecord<OUT> streamRecord) throws Exception {
output.emitRecord(streamRecord);
this.sourceMetricGroup.recordEmitted();
- if (streamRecord.hasTimestamp()) {
- this.sourceMetricGroup.eventTimeEmitted(streamRecord.getTimestamp());
+ long timestamp = streamRecord.getTimestamp();
+ if (timestamp != TimestampAssigner.NO_TIMESTAMP) {
Review comment:
It doesn't make sense to keep the check as `SourceOutputWithWatermarks#collect` will never set the flag.
But I created https://issues.apache.org/jira/browse/FLINK-23858 to clarify it further and potentially deprecate the old uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
}, {
"hash" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362",
"triggerID" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"triggerType" : "PUSH"
}, {
"hash" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22403",
"triggerID" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"triggerType" : "PUSH"
}, {
"hash" : "2178ac743f87edaf1792db765a0fc0b5b058c66e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22419",
"triggerID" : "2178ac743f87edaf1792db765a0fc0b5b058c66e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11392b6d7107d00ba49f39b8675c4a98ab2cebb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362)
* 0bb725aeff9d4128b2693f15c023d3f9dfff16fe Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22403)
* 2178ac743f87edaf1792db765a0fc0b5b058c66e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #16851:
URL: https://github.com/apache/flink/pull/16851#discussion_r691078810
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -461,8 +462,9 @@ public MetricTrackingOutput(
public void emitRecord(StreamRecord<OUT> streamRecord) throws Exception {
output.emitRecord(streamRecord);
this.sourceMetricGroup.recordEmitted();
- if (streamRecord.hasTimestamp()) {
- this.sourceMetricGroup.eventTimeEmitted(streamRecord.getTimestamp());
+ long timestamp = streamRecord.getTimestamp();
+ if (timestamp != TimestampAssigner.NO_TIMESTAMP) {
Review comment:
Can we keep the `streamRecord.hasTimestamp()` check? Now it implies that `TimestampAssigner.NO_TIMESTAMP` is always the same value as the return of `streamRecord.getTimestamp()` if no timestamp is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #16851:
URL: https://github.com/apache/flink/pull/16851#discussion_r691950196
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -461,8 +462,9 @@ public MetricTrackingOutput(
public void emitRecord(StreamRecord<OUT> streamRecord) throws Exception {
output.emitRecord(streamRecord);
this.sourceMetricGroup.recordEmitted();
- if (streamRecord.hasTimestamp()) {
- this.sourceMetricGroup.eventTimeEmitted(streamRecord.getTimestamp());
+ long timestamp = streamRecord.getTimestamp();
+ if (timestamp != TimestampAssigner.NO_TIMESTAMP) {
Review comment:
Thanks for opening the follow-up although the discussion goes already deeper than expected...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #16851: [FLINK-23776][streaming] Fix emission of timestamp-less records in Sources.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #16851:
URL: https://github.com/apache/flink/pull/16851#discussion_r691078810
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -461,8 +462,9 @@ public MetricTrackingOutput(
public void emitRecord(StreamRecord<OUT> streamRecord) throws Exception {
output.emitRecord(streamRecord);
this.sourceMetricGroup.recordEmitted();
- if (streamRecord.hasTimestamp()) {
- this.sourceMetricGroup.eventTimeEmitted(streamRecord.getTimestamp());
+ long timestamp = streamRecord.getTimestamp();
+ if (timestamp != TimestampAssigner.NO_TIMESTAMP) {
Review comment:
Can we keep the `streamRecord.hasTimestamp()` check? Now it implies that `TimestampAssigner.NO_TIMESTAMP` is always the same value as the return of `streamRecord.getTimestamp()` if no timestamp is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix emission of timestamp-less records in Sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix handling of timestamp-less records in Source metrics.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
}, {
"hash" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362",
"triggerID" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"triggerType" : "PUSH"
}, {
"hash" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22403",
"triggerID" : "0bb725aeff9d4128b2693f15c023d3f9dfff16fe",
"triggerType" : "PUSH"
}, {
"hash" : "2178ac743f87edaf1792db765a0fc0b5b058c66e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22419",
"triggerID" : "2178ac743f87edaf1792db765a0fc0b5b058c66e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0bb725aeff9d4128b2693f15c023d3f9dfff16fe Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22403)
* 2178ac743f87edaf1792db765a0fc0b5b058c66e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22419)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #16851: [FLINK-23776][streaming] Fix emission of timestamp-less records in Sources.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #16851:
URL: https://github.com/apache/flink/pull/16851#issuecomment-899772155
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22327",
"triggerID" : "9bd96fbf608b8f3a4e5682e74f3583dc14ae5c37",
"triggerType" : "PUSH"
}, {
"hash" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362",
"triggerID" : "11392b6d7107d00ba49f39b8675c4a98ab2cebb1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 11392b6d7107d00ba49f39b8675c4a98ab2cebb1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=22362)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org