You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/08/14 11:26:30 UTC

[GitHub] arina-ielchiieva commented on a change in pull request #1428: DRILL-6670: align Parquet TIMESTAMP_MICROS logical type handling with earlier versions + minor fixes

arina-ielchiieva commented on a change in pull request #1428: DRILL-6670: align Parquet TIMESTAMP_MICROS logical type handling with earlier versions + minor fixes
URL: https://github.com/apache/drill/pull/1428#discussion_r209915434
 
 

 ##########
 File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet2/TestDrillParquetReader.java
 ##########
 @@ -33,20 +33,20 @@
 import org.junit.Test;
 
 public class TestDrillParquetReader extends BaseTestQuery {
-  // enable decimal data type
+  // enable decimal data type and make sure DrillParquetReader is used to handle test queries
   @BeforeClass
   public static void enableDecimalDataType() throws Exception {
     test(String.format("alter session set `%s` = true", PlannerSettings.ENABLE_DECIMAL_DATA_TYPE_KEY));
 
 Review comment:
   Please use alterSession / resetSession methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services