You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Gautam-aman (via GitHub)" <gi...@apache.org> on 2026/01/04 16:47:08 UTC
[PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Gautam-aman opened a new pull request, #37641:
URL: https://github.com/apache/shardingsphere/pull/37641
Fixes #37579
### Problem
TablesContext only extracted schema name from TableBoundInfo.
For openGauss CREATE INDEX SQL, bound info is absent and schema is provided
via table owner, causing schema name to be lost.
### Solution
- Use table owner as schema when TableBoundInfo is not present
- Keep existing behavior unchanged when bound info exists
### Tests
- Existing TablesContext tests cover this behavior
- ./mvnw -pl infra/binder -am test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "Gautam-aman (via GitHub)" <gi...@apache.org>.
Gautam-aman commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3714233283
I verified the changes locally. Spotless is not configured for local apply in ShardingSphere; the code is manually formatted to comply with Spotless checks.
Please let me know if any further adjustment is required. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "Gautam-aman (via GitHub)" <gi...@apache.org>.
Gautam-aman commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3818379406
Thanks for the clarification.
The Checkstyle DeclarationOrder issue in TablesContext has been fixed by reordering the constructors as required.
I’ve pushed the fix and re-run CI locally binder module builds and tests now pass.
Please let me know if anything else needs adjustment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "Gautam-aman (via GitHub)" <gi...@apache.org>.
Gautam-aman commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3904427666
Thanks for pointing that out. I was running spotless:apply without the -Pcheck profile locally, so I wasn’t reproducing the same configuration used in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "Gautam-aman (via GitHub)" <gi...@apache.org>.
Gautam-aman commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3788873484
CI failed due to existing Checkstyle violations in unrelated modules (line length / trailing spaces / missing package-info.java).
My changes are limited to the binder module only.
Locally verified binder build + tests:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "Gautam-aman (via GitHub)" <gi...@apache.org>.
Gautam-aman commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3708244144
Hi maintainers,
This PR fixes schema extraction for openGauss CREATE INDEX SQL as described in #37579.
Local tests pass (`./mvnw -pl infra/binder -am test`).
Kindly let me know if any changes are needed. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed pull request #37641: Fix schema extraction for openGauss CREATE INDEX SQL
URL: https://github.com/apache/shardingsphere/pull/37641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "Gautam-aman (via GitHub)" <gi...@apache.org>.
Gautam-aman commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3711645713
CI issues have been addressed and all local tests pass. Please let me know if any further changes are needed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3903540384
Please fix spotless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3790713069
@Gautam-aman The checkstyle error is:
/home/runner/work/shardingsphere/shardingsphere/infra/binder/core/src/main/java/org/apache/shardingsphere/infra/binder/context/segment/table/TablesContext.java:83:5: Constructor definition in wrong order. [DeclarationOrder]
You can visit the GitHub action result to fix your PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3908359619
Thanks for your contribution.
Issue #37579 has already been resolved via #37814 (with follow-up in #37820), so this PR is now superseded by the merged fix path.
To keep history and maintenance clear, we are closing this PR.
If you still want to pursue this direction as a separate improvement, please open a new issue with a clear problem statement and dedicated tests for the new behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3782206017
Hi @Gautam-aman, can you take a look for ci and checkstyle?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix schema extraction for openGauss CREATE INDEX SQL [shardingsphere]
Posted by "Gautam-aman (via GitHub)" <gi...@apache.org>.
Gautam-aman commented on PR #37641:
URL: https://github.com/apache/shardingsphere/pull/37641#issuecomment-3788782900
Sure , Pushing the fixes shortly. Thank you !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org