You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "chunhui shen (JIRA)" <ji...@apache.org> on 2012/07/06 07:59:33 UTC
[jira] [Created] (HBASE-6336) Split point should not be equal with
start row or end row
chunhui shen created HBASE-6336:
-----------------------------------
Summary: Split point should not be equal with start row or end row
Key: HBASE-6336
URL: https://issues.apache.org/jira/browse/HBASE-6336
Project: HBase
Issue Type: Bug
Reporter: chunhui shen
Should we allow split point equal with region's start row or end row?
{code}
// if the midkey is the same as the first and last keys, then we cannot
// (ever) split this region.
if (this.comparator.compareRows(mk, firstKey) == 0 &&
this.comparator.compareRows(mk, lastKey) == 0) {
if (LOG.isDebugEnabled()) {
LOG.debug("cannot split because midkey is the same as first or " +
"last row");
}
{code}
Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407787#comment-13407787 ]
Zhihong Ted Yu commented on HBASE-6336:
---------------------------------------
Good catch.
It is a bug.
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal to
start row or end row
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490384#comment-13490384 ]
Hudson commented on HBASE-6336:
-------------------------------
Integrated in HBase-0.94-security-on-Hadoop-23 #9 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/9/])
HBASE-7020 Backport HBASE-6336 Split point should not be equal to start row or end row (Sergey Shelukhin) (Revision 1400359)
Result = FAILURE
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
> Split point should not be equal to start row or end row
> -------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal to
start row or end row
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415875#comment-13415875 ]
ramkrishna.s.vasudevan commented on HBASE-6336:
-----------------------------------------------
@Ted
If you are going to commit, carry on Ted.
> Split point should not be equal to start row or end row
> -------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412795#comment-13412795 ]
stack commented on HBASE-6336:
------------------------------
@Ram Thanks. So, hbase-6059 added our writing of empty store files it seems. I remember that now. So, if we throw an exception because its empty but higher up we are returning split point of null -- that the empty region is not splittable -- it doesn't seem like an issue (its just ugly).
For sure we should commit Chunhui's patch on this issue.
Good stuff lads.
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "chunhui shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409185#comment-13409185 ]
chunhui shen commented on HBASE-6336:
-------------------------------------
@ram
Sorry, I'm not clear about your mean.
In current logic, we will getting an IOException in logs and return null for getSplitPoint.
Do you mean we directly return null for HFileBlockIndex#midkey() if (rootCount == 0) rather than throws an IOException?
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal to
start row or end row
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415887#comment-13415887 ]
Hudson commented on HBASE-6336:
-------------------------------
Integrated in HBase-TRUNK #3139 (See [https://builds.apache.org/job/HBase-TRUNK/3139/])
HBASE-6336 Split point should not be equal to start row or end row (Chunhui) (Revision 1362340)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
> Split point should not be equal to start row or end row
> -------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6336) Split point should not be equal with
start row or end row
Posted by "chunhui shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen updated HBASE-6336:
--------------------------------
Attachment: HBASE-6336.patch
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412504#comment-13412504 ]
ramkrishna.s.vasudevan commented on HBASE-6336:
-----------------------------------------------
@Stack
bq.If so, why we write a flush file if no KVs?
Yes we are writing an emtpy now. Incase of compaction we are creating an empty file. So once the region is split we compact, so there an empty file is created for an empty region.
See HBASE-6059 - Replaying recovered edits would make deleted data exist again
There i had a concern on creating an empty store file, but it was needed. So you feel any problem there Stack?
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6336) Split point should not be equal to
start row or end row
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6336:
----------------------------------
Summary: Split point should not be equal to start row or end row (was: Split point should not be equal with start row or end row)
> Split point should not be equal to start row or end row
> -------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "chunhui shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409121#comment-13409121 ]
chunhui shen commented on HBASE-6336:
-------------------------------------
@ram
In current logic, if no kvs in one region, we will failed getting split point because following code when call StoreFile.Reader.midkey()
{code}
if (rootCount == 0)
throw new IOException("HFile empty");
{code}
Do you mean allow to get split point for the above case? Or other?
We will catch above IOException and return null for getSplitPoint, I think it is ok...
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409178#comment-13409178 ]
ramkrishna.s.vasudevan commented on HBASE-6336:
-----------------------------------------------
bq.We will catch above IOException and return null for getSplitPoint, I think it is ok...
Yes.. this is better i felt. Because getting an IOException in logs makes someone think its a problem.
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6336) Split point should not be equal with
start row or end row
Posted by "chunhui shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen updated HBASE-6336:
--------------------------------
Component/s: regionserver
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408530#comment-13408530 ]
Hadoop QA commented on HBASE-6336:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12535332/HBASE-6336.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.coprocessor.TestClassLoading
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2339//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2339//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2339//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2339//console
This message is automatically generated.
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal to
start row or end row
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415874#comment-13415874 ]
Zhihong Ted Yu commented on HBASE-6336:
---------------------------------------
Integrated to trunk.
Thanks for the patch, Chunhui.
Thanks for the review, Stack and Ram.
> Split point should not be equal to start row or end row
> -------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "chunhui shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415868#comment-13415868 ]
chunhui shen commented on HBASE-6336:
-------------------------------------
Is there any problem for this issue?
I think we could commit it ...
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal to
start row or end row
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480646#comment-13480646 ]
Hudson commented on HBASE-6336:
-------------------------------
Integrated in HBase-0.94 #543 (See [https://builds.apache.org/job/HBase-0.94/543/])
HBASE-7020 Backport HBASE-6336 Split point should not be equal to start row or end row (Sergey Shelukhin) (Revision 1400359)
Result = SUCCESS
larsh :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
> Split point should not be equal to start row or end row
> -------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6336) Split point should not be equal to
start row or end row
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6336:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Resolving. Was committed to trunk. Could be backported. Lets open new issue to do that if wanted.
> Split point should not be equal to start row or end row
> -------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal to
start row or end row
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13416097#comment-13416097 ]
Hudson commented on HBASE-6336:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #96 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/96/])
HBASE-6336 Split point should not be equal to start row or end row (Chunhui) (Revision 1362340)
Result = FAILURE
tedyu :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
> Split point should not be equal to start row or end row
> -------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal to
start row or end row
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415873#comment-13415873 ]
ramkrishna.s.vasudevan commented on HBASE-6336:
-----------------------------------------------
I can commit this today Chunhui. We already have +1 on this.
> Split point should not be equal to start row or end row
> -------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6336) Split point should not be equal with
start row or end row
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6336:
----------------------------------
Fix Version/s: 0.96.0
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-6336) Split point should not be equal with
start row or end row
Posted by "chunhui shen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen reassigned HBASE-6336:
-----------------------------------
Assignee: chunhui shen
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412069#comment-13412069 ]
stack commented on HBASE-6336:
------------------------------
+1 on the patch.
@Ram when you say 'But here in the first region there are no kvs at all and hence we flush an empty file.'
What flush are you talking of? The close of the region on split? If so, why we write a flush file if no KVs? Do we? That don't seem right.
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6336) Split point should not be equal
with start row or end row
Posted by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13408176#comment-13408176 ]
ramkrishna.s.vasudevan commented on HBASE-6336:
-----------------------------------------------
I think this is fine.
One more thing we noticed here is Suppose
I have a table with no split keys. And i have very few data in that. Now if i try to split we split from
[] to [firstrow]
[firstrow] to []
Why we get first row as 1st region's end key is i have only one root index and it will select the first row as the midkey.
But here in the first region there are no kvs at all and hence we flush an empty file. Now when we again call split passing the table name for the first region we get an ioexception from
{code}
if (rootCount == 0)
throw new IOException("HFile empty");
{code}
It may not be a bug but just found this.
> Split point should not be equal with start row or end row
> ---------------------------------------------------------
>
> Key: HBASE-6336
> URL: https://issues.apache.org/jira/browse/HBASE-6336
> Project: HBase
> Issue Type: Bug
> Components: regionserver
> Reporter: chunhui shen
> Assignee: chunhui shen
> Fix For: 0.96.0
>
> Attachments: HBASE-6336.patch
>
>
> Should we allow split point equal with region's start row or end row?
> {code}
> // if the midkey is the same as the first and last keys, then we cannot
> // (ever) split this region.
> if (this.comparator.compareRows(mk, firstKey) == 0 &&
> this.comparator.compareRows(mk, lastKey) == 0) {
> if (LOG.isDebugEnabled()) {
> LOG.debug("cannot split because midkey is the same as first or " +
> "last row");
> }
> {code}
> Here, I think it is a mistake.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira