[GitHub] [airflow] yuqian90 commented on a change in pull request #5189: [AIRFLOW-4415] skip status propagation

[GitBox <gi...@apache.org>]

yuqian90 commented on a change in pull request #5189: [AIRFLOW-4415] skip status propagation
URL: https://github.com/apache/airflow/pull/5189#discussion_r329533503
 
 

 ##########
 File path: airflow/models/baseoperator.py
 ##########
 @@ -264,7 +264,7 @@ def __init__(
         on_failure_callback: Optional[Callable] = None,
         on_success_callback: Optional[Callable] = None,
         on_retry_callback: Optional[Callable] = None,
-        trigger_rule: str = TriggerRule.ALL_SUCCESS,
+        trigger_rule: str = TriggerRule.NONE_FAILED,
 
 Review comment:
   This is changing the default trigger_rule to NONE_FAILED. So previously if any immediate upstream job is skipped, a task would not run. But after this PR this behaviour changes. A task will run even if its upstream tasks were skipped. That's going to cause problems for people relying on the current behaviour. Why not leave this change out and tell users to set the trigger rule to NONE_FAILED only if they want this new behaviour?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services