You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "David Byrne (JIRA)" <ji...@apache.org> on 2007/12/15 03:43:43 UTC

[jira] Created: (HTTPCORE-133) Clone support

Clone support
-------------

                 Key: HTTPCORE-133
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-133
             Project: HttpComponents Core
          Issue Type: Improvement
          Components: HttpCore
            Reporter: David Byrne
            Priority: Minor


It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. If I want to clone an entity, I can clone a entity and not figure out if it's UrlEncodedFormEntity, FileEntity, etc. So far, HttpEntity is the only interface in HttpCore that I've wanted to clone. I'm going to submit another ticket for client.

Thanks,
David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Updated: (HTTPCORE-133) Clone support

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCORE-133:
---------------------------------------

        Fix Version/s: 4.0-beta1
    Affects Version/s:     (was: 4.0-beta1)
                       4.0-alpha6

> Clone support
> -------------
>
>                 Key: HTTPCORE-133
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-133
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.0-alpha6
>            Reporter: David Byrne
>            Priority: Minor
>             Fix For: 4.0-beta1
>
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. If I want to clone an entity, I can clone a entity and not figure out if it's UrlEncodedFormEntity, FileEntity, etc. So far, HttpEntity is the only interface in HttpCore that I've wanted to clone. I'm going to submit another ticket for client.
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Resolved: (HTTPCORE-133) Clone support

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCORE-133.
----------------------------------------

    Resolution: Fixed

I added support for Cloneable, #clone() to all basic HTTP message elements and non-streaming (!) HTTP entities. I see no reasonable way of providing cloning support to HTTP messages firstly because Cloneable, #clone() combo is simply not suited for cloning complex compound objects and secondly because streaming entities cannot be cloned. 

David,
Please review.

Oleg  

> Clone support
> -------------
>
>                 Key: HTTPCORE-133
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-133
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.0-alpha6
>            Reporter: David Byrne
>            Priority: Minor
>             Fix For: 4.0-beta1
>
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. If I want to clone an entity, I can clone a entity and not figure out if it's UrlEncodedFormEntity, FileEntity, etc. So far, HttpEntity is the only interface in HttpCore that I've wanted to clone. I'm going to submit another ticket for client.
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

[jira] Updated: (HTTPCORE-133) Clone support

Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCORE-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski updated HTTPCORE-133:
---------------------------------------

    Affects Version/s: 4.0-beta1

I am going to implement Cloneable for all classes that already have a #copy method or where ability to produce shallow copies may be useful. This said, I am sure cloning entities makes sense (at least to me). Why would you want that? Besides, streaming entities simply cannot be cloned because they are essentially read-once.

Oleg 

> Clone support
> -------------
>
>                 Key: HTTPCORE-133
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-133
>             Project: HttpComponents Core
>          Issue Type: Improvement
>          Components: HttpCore
>    Affects Versions: 4.0-beta1
>            Reporter: David Byrne
>            Priority: Minor
>
> It would be nice to have a clone method for some of the classes that don't have getters & setters exposed for all of their fields. Where relevant, the clone method could be in the interface, so that it doesn't matter which implementing class is being used. If I want to clone an entity, I can clone a entity and not figure out if it's UrlEncodedFormEntity, FileEntity, etc. So far, HttpEntity is the only interface in HttpCore that I've wanted to clone. I'm going to submit another ticket for client.
> Thanks,
> David Byrne

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org