[jira] Updated: (HIVE-1124) create view should expand the query text consistently

["John Sichi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1124:
-----------------------------

    Attachment: HIVE-1124.1.patch

The problem turned out to be with the way we resolve common subexpressions for matching expressions in the SELECT list and GROUP BY.  As soon as we saw the match, we were skipping over the SELECT item subtree without performing any translations, leading to the inconsistency later on when the view was referenced.

The fix in this patch is a bit involved, since I had to make the UnparseTranslator capable of copying the translations for the common subexpressions.

I have not yet run through all tests yet, but the patch is available for review now.


> create view should expand the query text consistently
> -----------------------------------------------------
>
>                 Key: HIVE-1124
>                 URL: https://issues.apache.org/jira/browse/HIVE-1124
>             Project: Hadoop Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0
>            Reporter: Zheng Shao
>            Assignee: John Sichi
>         Attachments: HIVE-1124.1.patch
>
>
> We should expand the omitted alias in the same way in "select" and in "group by".
> Hive "Group By" recognize "group by" expressions by comparing the literal string.
> {code}
> hive> create view zshao_view as select d, count(1) as cnt from zshao_tt group by d;
> OK
> Time taken: 0.286 seconds
> hive> select * from zshao_view;
> FAILED: Error in semantic analysis: line 1:7 Expression Not In Group By Key d in definition of VIEW zshao_view [
> select d, count(1) as `cnt` from `zshao_tt` group by `zshao_tt`.`d`
> ] used as zshao_view at line 1:14
> {code}
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.