You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "spyhunter99 (via GitHub)" <gi...@apache.org> on 2024/03/30 15:12:00 UTC
[PR] JSPWIKI-1188 system property expansion [jspwiki]
spyhunter99 opened a new pull request, #330:
URL: https://github.com/apache/jspwiki/pull/330
see https://issues.apache.org/jira/browse/JSPWIKI-1188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]
Posted by "juanpablo-santos (via GitHub)" <gi...@apache.org>.
juanpablo-santos commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080766504
re. the build failure, MailUtilTest does send a mail to a local mailbox, and seems that up recently it doesn't allow mail sending if not using at least TLSv1.2. Currently running build at master should fix that issue, and I've also enabled console output on surefire on test failures/errors so hopefully debugging will be easier from now on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]
Posted by "juanpablo-santos (via GitHub)" <gi...@apache.org>.
juanpablo-santos merged PR #330:
URL: https://github.com/apache/jspwiki/pull/330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080934993
could try dumpster. it's a pure java, unit test only, mail server setup. We used it on apache juddi for integration tests. works fairly well for plain text stuff. never tried it with ssl though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]
Posted by "juanpablo-santos (via GitHub)" <gi...@apache.org>.
juanpablo-santos commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080704623
Hi, just added a commit on the PR to also allow system env variable expansion, with the tests also passing; let's merge this and get a look to ci build then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080687905
cycling back around to this. looks like the last commit i made does it fact work.
i'm not sure why the tests failed (works on my machine lol). test failure is related to email notifications...i didn't touch any of that. any guidance from the JSPWiki team?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]
Posted by "spyhunter99 (via GitHub)" <gi...@apache.org>.
spyhunter99 commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2028797198
this actually didn't work when i tested it in tomcat. investigating now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] JSPWIKI-1188 system property expansion [jspwiki]
Posted by "juanpablo-santos (via GitHub)" <gi...@apache.org>.
juanpablo-santos commented on PR #330:
URL: https://github.com/apache/jspwiki/pull/330#issuecomment-2080726515
this is now merged in 2.12.2-git-13, thanks! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jspwiki.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org