You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "SzyWilliam (via GitHub)" <gi...@apache.org> on 2023/09/05 16:26:22 UTC

[GitHub] [ratis] SzyWilliam commented on pull request #914: RATIS-1883. Next Index should be always larger than Match Index in Gr…

SzyWilliam commented on PR #914:
URL: https://github.com/apache/ratis/pull/914#issuecomment-1706950095

   > The follower cannot clear the existing log. Otherwise, the committed entries can be removed.
   
   Totally agree. That's the exact reason why the test fails. In `testBootstrapReconf`, we first start the new servers [here](https://github.com/apache/ratis/blob/88405b037ac9db4471603dfdd8ddc7c542f0229c/ratis-server/src/test/java/org/apache/ratis/server/impl/RaftReconfigurationBaseTest.java#L405), but then restart the same new servers again [here](https://github.com/apache/ratis/blob/88405b037ac9db4471603dfdd8ddc7c542f0229c/ratis-server/src/test/java/org/apache/ratis/server/impl/RaftReconfigurationBaseTest.java#L425). The tests will pass if we set `startNewPeer` to false.
   
   I agree that we should enforce matchIndex safety. Thought `testBootstrapReconf` was a deliberate test for robustness before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org