You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/30 14:51:24 UTC

[GitHub] [incubator-nuttx] v01d commented on pull request #1669: nrf52: improvements in modularity

v01d commented on pull request #1669:
URL: https://github.com/apache/incubator-nuttx/pull/1669#issuecomment-683429860


   I have looked at the changes and they look good. I can't really verify that every feature that you have assigned to each chip is indeed correct but it seems you are more familiar with other chips than me. 
   
   I have a few comments though:
   1. It seems strange to consider a specific chip as a family with a define such as `ARCH_FAMILY_NRF52833`. At that point we should be talking about that chip. Otherwise, it should refer to something like `ARCH_FAMILY_NRF5283x` (if that makes sense).
   2. If the idea is to use ifdefs based on features not chips, couldn't we do this completely from Kconfig? I see some mappings from chip/family to features in Kconfig and others in headers.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org