You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/03/20 22:53:12 UTC
[GitHub] [calcite] julianhyde commented on a change in pull request #1108:
[CALCITE-883] Support RESPECT NULLS, IGNORE NULLS option for lead, lag,
first_value, last_value function
julianhyde commented on a change in pull request #1108: [CALCITE-883] Support RESPECT NULLS, IGNORE NULLS option for lead, lag, first_value, last_value function
URL: https://github.com/apache/calcite/pull/1108#discussion_r267578026
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlAggFunction.java
##########
@@ -38,6 +38,7 @@
private final boolean requiresOrder;
private final boolean requiresOver;
private final Optionality requiresGroupOrder;
+ private final Boolean ignoreNulls;
Review comment:
That does sound like an attractive option. The other ways to represent RESPECT NULLS in SqlNode - namely to modify the operator, and to extend SqlCall - have significant problems.
Let's have a discussion in the JIRA issue, and agree a design. I'm sorry that you wrote a lot of code before we had the design discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services