You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "torwig (via GitHub)" <gi...@apache.org> on 2023/06/12 13:14:27 UTC

[GitHub] [incubator-kvrocks] torwig commented on pull request #1493: Fix duplicately join the task runner

torwig commented on PR #1493:
URL: https://github.com/apache/incubator-kvrocks/pull/1493#issuecomment-1587323131

   @git-hulk Yes, `Server::Stop` will cancel and `Server::Join` will join all threads.
   Additionally, here https://github.com/apache/incubator-kvrocks/blob/unstable/src/common/task_runner.cc#L48 should we stop joining threads when the first call to `util::ThreadJoin` or just log an error and continue joining other threads?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org