You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2026/07/24 15:10:52 UTC
[PR] Detect linked issues at the end of PR bodies in provider testing issue [airflow]
shahar1 opened a new pull request, #70396:
URL: https://github.com/apache/airflow/pull/70396
The provider testing issue generator (`breeze release-management generate-issue-content-providers`) silently missed linked issues whose reference is the last thing in the PR body — a common shape, since `Fixes #NNNNN` often sits on the final line. `ISSUE_MATCH_IN_BODY` (`r" #([0-9]+)[^0-9]"`) requires a non-digit character *after* the number, which doesn't exist at end of string after the body's lines are joined.
Concrete occurrence: in the google 22.3.0rc1 testing issue (#70355), PR #69161 (body ending with `Fixes #53843`) was rendered with no linked issues, and the release manager had to add #53843 by hand.
Replacing the trailing `[^0-9]` with a negative lookahead `(?![0-9])` matches the same references without requiring a trailing character. Verified against the real #69161 body: the old pattern finds nothing, the new one finds 53843; mid-body references behave identically.
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Fable 5)
Generated-by: Claude Code (Fable 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Detect linked issues at the end of PR bodies in provider testing issue [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #70396:
URL: https://github.com/apache/airflow/pull/70396#discussion_r3653202273
##########
dev/breeze/tests/test_release_management_commands.py:
##########
@@ -292,3 +293,18 @@ def test_get_package_version_possibly_from_stable_txt_for_java_sdk(
stable_txt.parent.mkdir(parents=True)
stable_txt.write_text(stable_txt_content)
assert get_package_version_possibly_from_stable_txt("java-sdk") == expected_version
+
+
+@pytest.mark.parametrize(
+ ("body", "expected"),
+ [
+ ("Some description closes: #12345 and more text", [12345]),
+ # reference at the very end of the body (e.g. "Fixes #53843" as the last line)
+ ("Generated-by: some agent Fixes #53843", [53843]),
+ ("related: #111, also see #222", [111, 222]),
Review Comment:
nit, optional — the fix also cures adjacent references, since the old `[^0-9]` consumed the separator that the next match needed. A case pinning that behaviour down:
```suggestion
("related: #111, also see #222", [111, 222]),
("adjacent references see #111 #222", [111, 222]),
```
##########
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##########
@@ -256,7 +256,7 @@
SOURCE_DIR_PATH = str(AIRFLOW_ROOT_PATH)
PR_PATTERN = re.compile(r".*\(#([0-9]+)\)")
PR_REFERENCE_PATTERN = re.compile(r"#([0-9]+)")
-ISSUE_MATCH_IN_BODY = re.compile(r" #([0-9]+)[^0-9]")
+ISSUE_MATCH_IN_BODY = re.compile(r" #([0-9]+)(?![0-9])")
Review Comment:
nit — `dev/assign_cherry_picked_prs_with_milestone.py:50` still carries a byte-identical copy of the *old* pattern. I checked: it's dead code there — defined but never referenced in that file — so nothing is actually broken. But it now diverges from this one, and it's the first hit anyone gets greping for `ISSUE_MATCH_IN_BODY`. Deleting it in this PR would save the next person the confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Detect linked issues at the end of PR bodies in provider testing issue [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #70396:
URL: https://github.com/apache/airflow/pull/70396#issuecomment-5090478370
### Backport failed to create: v3-3-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/30260107757'> Run details </a>
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v3-3-test</td>
<td><a href="https://github.com/apache/airflow/commit/9f8629c5929d0c22380e1d30e94c6711fa93003c"><img src='https://img.shields.io/badge/Commit-9f8629c-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker 9f8629c v3-3-test
```
This should apply the commit to the v3-3-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
If you don't have cherry-picker installed, see the [installation guide](https://github.com/apache/airflow/blob/main/dev/README.md#how-to-backport-pr-with-cherry-picker-cli).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Detect linked issues at the end of PR bodies in provider testing issue [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #70396:
URL: https://github.com/apache/airflow/pull/70396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org