You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/22 22:24:43 UTC
[GitHub] [incubator-seatunnel] tangaot opened a new pull request, #1731: [Improve][docs] Add doc zh-CN seatunnel for flink deployment.md instal…
tangaot opened a new pull request, #1731:
URL: https://github.com/apache/incubator-seatunnel/pull/1731
[Improve][docs] Add doc zh-CN seatunnel for flink deployment.md installation.md quick-start.md
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
This pull request adds Chinese (zh-CN) documentation about seatunnel quick-start, installation and deployment on Flink.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #1731: [Improve][docs] Add doc zh-CN seatunnel for flink deployment.md instal…
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #1731:
URL: https://github.com/apache/incubator-seatunnel/pull/1731#issuecomment-1107695918
> @tangaot Thanks for your patch, but I remember we will not maintain Chinese doc anymore, so is this PR acceptable? @CalvinKirs My opinion is to close this PR.
Let's discuss this in an email, I can't find a corresponding discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1731: [Improve][docs] Add doc zh-CN seatunnel for flink deployment.md instal…
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1731:
URL: https://github.com/apache/incubator-seatunnel/pull/1731#issuecomment-1107392005
@tangaot Thanks for your patch, but I remember we will not maintain Chinese doc anymore, so is this PR acceptable? @CalvinKirs My opinion is to close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] zhongjiajie commented on pull request #1731: [Improve][docs] Add doc zh-CN seatunnel for flink deployment.md instal…
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #1731:
URL: https://github.com/apache/incubator-seatunnel/pull/1731#issuecomment-1107692226
I agree with you @ruanwenjun , we will have Chinese, but only with some black magic transform from English docs. we already have an issue with it https://github.com/apache/incubator-seatunnel/issues/1437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun closed pull request #1731: [Improve][docs] Add doc zh-CN seatunnel for flink deployment.md instal…
Posted by GitBox <gi...@apache.org>.
ruanwenjun closed pull request #1731: [Improve][docs] Add doc zh-CN seatunnel for flink deployment.md instal…
URL: https://github.com/apache/incubator-seatunnel/pull/1731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1731: [Improve][docs] Add doc zh-CN seatunnel for flink deployment.md instal…
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1731:
URL: https://github.com/apache/incubator-seatunnel/pull/1731#issuecomment-1107779403
> > @tangaot Thanks for your patch, but I remember we will not maintain Chinese doc anymore, so is this PR acceptable? @CalvinKirs My opinion is to close this PR.
>
> Let's discuss this in an email, I can't find a corresponding discussion
I started a discussion at [this thread ](https://lists.apache.org/thread/j1vo1yccqp79bv69bzokbqq3n58zytql), this PR needs to be discussed before we can deal with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1731: [Improve][docs] Add doc zh-CN seatunnel for flink deployment.md instal…
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1731:
URL: https://github.com/apache/incubator-seatunnel/pull/1731#issuecomment-1109312191
After discuss in this [mail thread ](https://lists.apache.org/thread/j1vo1yccqp79bv69bzokbqq3n58zytql), we find it's better to use tools to generate the Chinese doc, and now we will not receive the PR about Chinese doc. Still thanks for your working, I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org