You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2015/03/27 02:12:45 UTC
Review Request 32559: Add Kerberos support to the scheduler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
Description
-------
Support authenticating to the scheduler API with Kerberos.
Diffs
-----
config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
src/main/python/apache/aurora/client/hooks/BUILD 49d73dfddbcee97ddde1a483f6697865d2566508
src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
src/test/python/apache/aurora/client/hooks/BUILD 43f59bc5a2397ad851211e064d83ef6e6de81972
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
Diff: https://reviews.apache.org/r/32559/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > examples/vagrant/provision-dev-cluster.sh, line 20
> > <https://reviews.apache.org/r/32559/diff/2/?file=907384#file907384line20>
> >
> > Is this needed to build kerberos in the test script? Do we need to build it from source? Can we just apt-get install kerb directly?
We build from source to get access to the "make testrealm" target. Installing the OS one would require more configuration (as it's intended for a production deployment). I'll drop a TODO.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java, lines 31-32
> > <https://reviews.apache.org/r/32559/diff/2/?file=907387#file907387line31>
> >
> > These don't appear to be used elsewhere, make them private?
Good catch, done.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java, line 38
> > <https://reviews.apache.org/r/32559/diff/2/?file=907387#file907387line38>
> >
> > This exception is caught in the servlet filter and its message is logged, so it would probably be good to include a message here when we throw it?
Added.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java, lines 82-83
> > <https://reviews.apache.org/r/32559/diff/2/?file=907389#file907389line82>
> >
> > Fits on a single line.
Nope, semicolon is in column 101.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, line 47
> > <https://reviews.apache.org/r/32559/diff/2/?file=907390#file907390line47>
> >
> > Fix.
Oops (fixed).
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, line 113
> > <https://reviews.apache.org/r/32559/diff/2/?file=907390#file907390line113>
> >
> > I feel like it'd be better to just let people specify a path to their jaas config on the command line rather than specifying the individual pieces so that we can generate a config for them. That way they'd have control over the pieces we don't expose as command line args (e.g. debug on/off, etc.).
I buy debug (I'll add a debug=$debug$ line), but I feel like JAAS is sufficiently complex that we want to insulate our users from its intricasies. I *really* wish there was a `GssCredential.fromKeyTab(byte[])` method that would let us avoid this dance altogether.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, line 132
> > <https://reviews.apache.org/r/32559/diff/2/?file=907390#file907390line132>
> >
> > If we do decide to stick with generating the jaas conf it might be useful to either write out the path to the generated file or write out the contents of the file to the log so that operators can inspect the config?
This line writes the generated config.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java, line 34
> > <https://reviews.apache.org/r/32559/diff/2/?file=907393#file907393line34>
> >
> > Fill in.
Doc'd
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java, line 20
> > <https://reviews.apache.org/r/32559/diff/2/?file=907397#file907397line20>
> >
> > Add a negative test case?
Done.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java, line 42
> > <https://reviews.apache.org/r/32559/diff/2/?file=907398#file907398line42>
> >
> > It feels like most of this stuff can be tested directly with a mock request/response/chain rather than starting up an http server.
> >
> > I think it's good to have integration tests for this as well, but we can probably simplify those to test the happy/sad path for integration tests and save testing all the corners for the unit test with mocks.
As written the class under test has 100% coverage with this integration test. (I actually found the IT easier to write since I have access to ClientBuilder, rather than mocking HttpServletRequest/HttpServletResponse methods)
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java, line 54
> > <https://reviews.apache.org/r/32559/diff/2/?file=907398#file907398line54>
> >
> > kill
done.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh, lines 71-72
> > <https://reviews.apache.org/r/32559/diff/2/?file=907399#file907399line71>
> >
> > We should undo this change after running this test, otherwise subsequent end to end test runs will fail?
> >
> > Or alternately just set up a separate service for scheduler w/ kerberos and stop the normal scheduler, start the kerb one, run tests, then stop/start in reverse?
Good suggestion, I created a separate upstart job.
> On March 27, 2015, 11:09 a.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java, line 36
> > <https://reviews.apache.org/r/32559/diff/2/?file=907396#file907396line36>
> >
> > It feels like we're missing a few test cases here. If we keep it, we should test the jaas config generation, we should test that the system property is restored, etc.
Most of the stuff in this class is glue that's really difficult to test without PowerMock (static method and constructor mocking). Since an error in this module will cause a failure immediately at application startup I think we're okay sacrificing a bit of test coverage here. One test I'd want to write, for example, is that gssManager.createCredential is called within a PrivilegedAction (where there's a threadlocal that makes it work), but not seeing a straightforward way to test that given the way the API works.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78075
-----------------------------------------------------------
On March 26, 2015, 6:23 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 6:23 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Joshua Cohen <jc...@apache.org>.
> On March 27, 2015, 6:09 p.m., Joshua Cohen wrote:
> > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java, line 42
> > <https://reviews.apache.org/r/32559/diff/2/?file=907398#file907398line42>
> >
> > It feels like most of this stuff can be tested directly with a mock request/response/chain rather than starting up an http server.
> >
> > I think it's good to have integration tests for this as well, but we can probably simplify those to test the happy/sad path for integration tests and save testing all the corners for the unit test with mocks.
>
> Kevin Sweeney wrote:
> As written the class under test has 100% coverage with this integration test. (I actually found the IT easier to write since I have access to ClientBuilder, rather than mocking HttpServletRequest/HttpServletResponse methods)
My main concern (and it's not a major one) is that having each test case spin up an HTTP server can slow things down versus pure unit tests. In my experience these things can stack up and make running tests more painful than they need to be.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78075
-----------------------------------------------------------
On March 27, 2015, 7:48 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 7:48 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78075
-----------------------------------------------------------
examples/vagrant/provision-dev-cluster.sh
<https://reviews.apache.org/r/32559/#comment126478>
Is this needed to build kerberos in the test script? Do we need to build it from source? Can we just apt-get install kerb directly?
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java
<https://reviews.apache.org/r/32559/#comment126480>
These don't appear to be used elsewhere, make them private?
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java
<https://reviews.apache.org/r/32559/#comment126477>
This exception is caught in the servlet filter and its message is logged, so it would probably be good to include a message here when we throw it?
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java
<https://reviews.apache.org/r/32559/#comment126490>
Fits on a single line.
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment126492>
Fix.
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment126494>
I feel like it'd be better to just let people specify a path to their jaas config on the command line rather than specifying the individual pieces so that we can generate a config for them. That way they'd have control over the pieces we don't expose as command line args (e.g. debug on/off, etc.).
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment126495>
If we do decide to stick with generating the jaas conf it might be useful to either write out the path to the generated file or write out the contents of the file to the log so that operators can inspect the config?
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java
<https://reviews.apache.org/r/32559/#comment126501>
Fill in.
src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java
<https://reviews.apache.org/r/32559/#comment126503>
It feels like we're missing a few test cases here. If we keep it, we should test the jaas config generation, we should test that the system property is restored, etc.
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java
<https://reviews.apache.org/r/32559/#comment126506>
Add a negative test case?
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java
<https://reviews.apache.org/r/32559/#comment126513>
It feels like most of this stuff can be tested directly with a mock request/response/chain rather than starting up an http server.
I think it's good to have integration tests for this as well, but we can probably simplify those to test the happy/sad path for integration tests and save testing all the corners for the unit test with mocks.
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java
<https://reviews.apache.org/r/32559/#comment126507>
kill
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh
<https://reviews.apache.org/r/32559/#comment126514>
We should undo this change after running this test, otherwise subsequent end to end test runs will fail?
Or alternately just set up a separate service for scheduler w/ kerberos and stop the normal scheduler, start the kerb one, run tests, then stop/start in reverse?
- Joshua Cohen
On March 27, 2015, 1:23 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 1:23 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78102
-----------------------------------------------------------
Master (45f2a84) is red with this patch.
./build-support/jenkins/build.sh
Downloading/unpacking argh>=0.8.1 (from watchdog==0.7.0->-r /dev/fd/63 (line 33))
Downloading argh-0.26.1.tar.gz
Saved ./third_party/argh-0.26.1.tar.gz
Running setup.py (path:/tmp/user/2395/pip_build_jenkins/argh/setup.py) egg_info for package argh
Downloading/unpacking pathtools>=0.1.1 (from watchdog==0.7.0->-r /dev/fd/63 (line 33))
Downloading pathtools-0.1.2.tar.gz
Saved ./third_party/pathtools-0.1.2.tar.gz
Running setup.py (path:/tmp/user/2395/pip_build_jenkins/pathtools/setup.py) egg_info for package pathtools
Downloading/unpacking zope.interface>=3.8.0 (from kazoo==1.3.1->twitter.common.zookeeper==0.3.3->-r /dev/fd/63 (line 32))
Saved ./third_party/zope.interface-4.1.2.tar.gz
Running setup.py (path:/tmp/user/2395/pip_build_jenkins/zope.interface/setup.py) egg_info for package zope.interface
warning: no previously-included files matching '*.dll' found anywhere in distribution
warning: no previously-included files matching '*.pyc' found anywhere in distribution
warning: no previously-included files matching '*.pyo' found anywhere in distribution
warning: no previously-included files matching '*.so' found anywhere in distribution
Successfully downloaded bottle CherryPy mako mesos.interface mock mox pex protobuf psutil pystachio pyyaml requests thrift twitter.common.app twitter.common.collections twitter.common.concurrent twitter.common.contextutil twitter.common.decorators twitter.common.dirutil twitter.common.exceptions twitter.common.http twitter.common.lang twitter.common.log twitter.common.metrics twitter.common.options twitter.common.process twitter.common.quantity twitter.common.recordio twitter.common.rpc twitter.common.string twitter.common.testing twitter.common.zookeeper watchdog MarkupSafe setuptools twitter.common.util futures kazoo argh pathtools zope.interface
Cleaning up...
+ ./build-support/python/isort-check
Bootstrapping isort @ 3.8.0
+ VIRTUALENV_VERSION=12.0.7
+ which python2.7
++ which python2.7
+ PY=/usr/bin/python2.7
+ echo 'Using /usr/bin/python2.7'
Using /usr/bin/python2.7
+++ dirname /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/../virtualenv
++ cd /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/..
++ pwd
+ HERE=/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support
+ '[' -f /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/virtualenv-12.0.7/BOOTSTRAPPED ']'
+ pushd /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support
~/jenkins-slave/workspace/AuroraBot/build-support ~/jenkins-slave/workspace/AuroraBot
+ curl -O https://pypi.python.org/packages/source/v/virtualenv/virtualenv-12.0.7.tar.gz
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:01 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:02 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:03 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:03 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:04 --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- 0:00:05 --:--:-- 0
0 1786k 0 15014 0 0 2251 0 0:13:32 0:00:06 0:13:26 3370
3 1786k 3 71014 0 0 9107 0 0:03:20 0:00:07 0:03:13 15498
9 1786k 9 170k 0 0 19449 0 0:01:34 0:00:08 0:01:26 33527
16 1786k 16 288k 0 0 30219 0 0:01:00 0:00:09 0:00:51 59207
20 1786k 20 358k 0 0 33552 0 0:00:54 0:00:10 0:00:44 70498
28 1786k 28 514k 0 0 44954 0 0:00:40 0:00:11 0:00:29 98k
44 1786k 44 788k 0 0 63739 0 0:00:28 0:00:12 0:00:16 147k
57 1786k 57 1032k 0 0 77218 0 0:00:23 0:00:13 0:00:10 183k
64 1786k 64 1160k 0 0 80656 0 0:00:22 0:00:14 0:00:08 175k
69 1786k 69 1248k 0 0 81516 0 0:00:22 0:00:15 0:00:07 187k
71 1786k 71 1272k 0 0 76818 0 0:00:23 0:00:16 0:00:07 144k
72 1786k 72 1288k 0 0 74284 0 0:00:24 0:00:17 0:00:07 98k
77 1786k 77 1381k 0 0 75181 0 0:00:24 0:00:18 0:00:06 69765
77 1786k 77 1392k 0 0 71874 0 0:00:25 0:00:19 0:00:06 46545
78 1786k 78 1397k 0 0 69226 0 0:00:26 0:00:20 0:00:06 30643
79 1786k 79 1428k 0 0 67504 0 0:00:27 0:00:21 0:00:06 33963
79 1786k 79 1428k 0 0 64523 0 0:00:28 0:00:22 0:00:06 29280
79 1786k 79 1428k 0 0 61795 0 0:00:29 0:00:23 0:00:06 9888
79 1786k 79 1428k 0 0 59287 0 0:00:30 0:00:24 0:00:06 7761
79 1786k 79 1428k 0 0 56976 0 0:00:32 0:00:25 0:00:07 6392
79 1786k 79 1428k 0 0 54341 0 0:00:33 0:00:26 0:00:07 0
79 1786k 79 1428k 0 0 52392 0 0:00:34 0:00:27 0:00:07 0
79 1786k 79 1428k 0 0 50579 0 0:00:36 0:00:28 0:00:08 0
79 1786k 79 1428k 0 0 48887 0 0:00:37 0:00:29 0:00:08 0
79 1786k 79 1428k 0 0 47304 0 0:00:38 0:00:30 0:00:08 0
79 1786k 79 1428k 0 0 45821 0 0:00:39 0:00:31 0:00:08 0
79 1786k 79 1428k 0 0 44428 0 0:00:41 0:00:32 0:00:09 0
79 1786k 79 1428k 0 0 43117 0 0:00:42 0:00:33 0:00:09 0
79 1786k 79 1428k 0 0 41881 0 0:00:43 0:00:34 0:00:09 0
79 1786k 79 1428k 0 0 40714 0 0:00:44 0:00:35 0:00:09 0
79 1786k 79 1428k 0 0 39611 0 0:00:46 0:00:36 0:00:10 0
79 1786k 79 1428k 0 0 38565 0 0:00:47 0:00:37 0:00:10 0
79 1786k 79 1428k 0 0 37574 0 0:00:48 0:00:38 0:00:10 0
79 1786k 79 1428k 0 0 36632 0 0:00:49 0:00:39 0:00:10 0
79 1786k 79 1428k 0 0 35736 0 0:00:51 0:00:40 0:00:11 0
79 1786k 79 1428k 0 0 34883 0 0:00:52 0:00:41 0:00:11 0
79 1786k 79 1428k 0 0 34070 0 0:00:53 0:00:42 0:00:11 0
79 1786k 79 1428k 0 0 33293 0 0:00:54 0:00:43 0:00:11 0
79 1786k 79 1428k 0 0 32552 0 0:00:56 0:00:44 0:00:12 0
79 1786k 79 1428k 0 0 31842 0 0:00:57 0:00:45 0:00:12 0
79 1786k 79 1428k 0 0 31163 0 0:00:58 0:00:46 0:00:12 0
79 1786k 79 1428k 0 0 30513 0 0:00:59 0:00:47 0:00:12 0
79 1786k 79 1428k 0 0 29889 0 0:01:01 0:00:48 0:00:13 0
79 1786k 79 1428k 0 0 29289 0 0:01:02 0:00:49 0:00:13 0
79 1786k 79 1428k 0 0 28714 0 0:01:03 0:00:50 0:00:13 0
79 1786k 79 1428k 0 0 28161 0 0:01:04 0:00:51 0:00:13 0
79 1786k 79 1428k 0 0 27628 0 0:01:06 0:00:52 0:00:14 0
79 1786k 79 1428k 0 0 27115 0 0:01:07 0:00:53 0:00:14 0
79 1786k 79 1428k 0 0 26621 0 0:01:08 0:00:54 0:00:14 0
79 1786k 79 1428k 0 0 26145 0 0:01:09 0:00:55 0:00:14 0
79 1786k 79 1428k 0 0 25686 0 0:01:11 0:00:56 0:00:15 0
79 1786k 79 1428k 0 0 25242 0 0:01:12 0:00:57 0:00:15 0
79 1786k 79 1428k 0 0 24813 0 0:01:13 0:00:58 0:00:15 0
79 1786k 79 1428k 0 0 24399 0 0:01:14 0:00:59 0:00:15 0
79 1786k 79 1428k 0 0 23998 0 0:01:16 0:01:00 0:00:16 0
79 1786k 79 1428k 0 0 23611 0 0:01:17 0:01:01 0:00:16 0
79 1786k 79 1428k 0 0 23235 0 0:01:18 0:01:02 0:00:16 0
79 1786k 79 1428k 0 0 22871 0 0:01:20 0:01:03 0:00:17 0
79 1786k 79 1428k 0 0 22519 0 0:01:21 0:01:04 0:00:17 0
79 1786k 79 1428k 0 0 22177 0 0:01:22 0:01:05 0:00:17 0
79 1786k 79 1428k 0 0 21846 0 0:01:23 0:01:06 0:00:17 0
79 1786k 79 1428k 0 0 21524 0 0:01:25 0:01:07 0:00:18 0
79 1786k 79 1428k 0 0 21211 0 0:01:26 0:01:08 0:00:18 0
79 1786k 79 1428k 0 0 20908 0 0:01:27 0:01:09 0:00:18 0
79 1786k 79 1428k 0 0 20613 0 0:01:28 0:01:10 0:00:18 0
79 1786k 79 1428k 0 0 20326 0 0:01:30 0:01:11 0:00:19 0
79 1786k 79 1428k 0 0 20047 0 0:01:31 0:01:12 0:00:19 0
79 1786k 79 1428k 0 0 19776 0 0:01:32 0:01:13 0:00:19 0
79 1786k 79 1428k 0 0 19512 0 0:01:33 0:01:14 0:00:19 0
79 1786k 79 1428k 0 0 19255 0 0:01:35 0:01:15 0:00:20 0
79 1786k 79 1428k 0 0 19004 0 0:01:36 0:01:16 0:00:20 0
79 1786k 79 1428k 0 0 18760 0 0:01:37 0:01:17 0:00:20 0
79 1786k 79 1428k 0 0 18523 0 0:01:38 0:01:18 0:00:20 0
79 1786k 79 1428k 0 0 18291 0 0:01:40 0:01:19 0:00:21 0
79 1786k 79 1428k 0 0 18065 0 0:01:41 0:01:20 0:00:21 0
79 1786k 79 1428k 0 0 17844 0 0:01:42 0:01:21 0:00:21 0
79 1786k 79 1428k 0 0 17629 0 0:01:43 0:01:22 0:00:21 0
79 1786k 79 1428k 0 0 17419 0 0:01:45 0:01:23 0:00:22 0
79 1786k 79 1428k 0 0 17213 0 0:01:46 0:01:24 0:00:22 0
79 1786k 79 1428k 0 0 17013 0 0:01:47 0:01:25 0:00:22 0
79 1786k 79 1428k 0 0 16817 0 0:01:48 0:01:26 0:00:22 0
79 1786k 79 1428k 0 0 16626 0 0:01:50 0:01:27 0:00:23 0
79 1786k 79 1428k 0 0 16439 0 0:01:51 0:01:28 0:00:23 0
79 1786k 79 1428k 0 0 16256 0 0:01:52 0:01:29 0:00:23 0
79 1786k 79 1428k 0 0 16077 0 0:01:53 0:01:30 0:00:23 0
79 1786k 79 1428k 0 0 15902 0 0:01:55 0:01:31 0:00:24 0
79 1786k 79 1428k 0 0 15731 0 0:01:56 0:01:32 0:00:24 0
79 1786k 79 1428k 0 0 15563 0 0:01:57 0:01:34 0:00:23 0
79 1786k 79 1428k 0 0 15399 0 0:01:58 0:01:35 0:00:23 0
79 1786k 79 1428k 0 0 15239 0 0:02:00 0:01:36 0:00:24 0
79 1786k 79 1428k 0 0 15082 0 0:02:01 0:01:37 0:00:24 0
79 1786k 79 1428k 0 0 14927 0 0:02:02 0:01:38 0:00:24 0
79 1786k 79 1428k 0 0 14777 0 0:02:03 0:01:39 0:00:24 0
79 1786k 79 1428k 0 0 14629 0 0:02:05 0:01:40 0:00:25 0
79 1786k 79 1428k 0 0 14484 0 0:02:06 0:01:41 0:00:25 0
79 1786k 79 1428k 0 0 14341 0 0:02:07 0:01:42 0:00:25 0
79 1786k 79 1428k 0 0 14202 0 0:02:08 0:01:43 0:00:25 0
79 1786k 79 1428k 0 0 14065 0 0:02:10 0:01:44 0:00:26 0
79 1786k 79 1428k 0 0 13931 0 0:02:11 0:01:45 0:00:26 0
79 1786k 79 1428k 0 0 13800 0 0:02:12 0:01:46 0:00:26 0
79 1786k 79 1428k 0 0 13671 0 0:02:13 0:01:47 0:00:26 0
79 1786k 79 1428k 0 0 13544 0 0:02:15 0:01:48 0:00:27 0
79 1786k 79 1428k 0 0 13419 0 0:02:16 0:01:49 0:00:27 0
79 1786k 79 1428k 0 0 13297 0 0:02:17 0:01:50 0:00:27 0
79 1786k 79 1428k 0 0 13177 0 0:02:18 0:01:51 0:00:27 0
79 1786k 79 1428k 0 0 13060 0 0:02:20 0:01:52 0:00:28 0
79 1786k 79 1428k 0 0 12944 0 0:02:21 0:01:53 0:00:28 0
79 1786k 79 1428k 0 0 12830 0 0:02:22 0:01:54 0:00:28 0
79 1786k 79 1428k 0 0 12719 0 0:02:23 0:01:55 0:00:28 0
79 1786k 79 1428k 0 0 12609 0 0:02:25 0:01:56 0:00:29 0
79 1786k 79 1428k 0 0 12501 0 0:02:26 0:01:57 0:00:29 0
79 1786k 79 1428k 0 0 12395 0 0:02:27 0:01:58 0:00:29 0
79 1786k 79 1428k 0 0 12291 0 0:02:28 0:01:59 0:00:29 0
79 1786k 79 1428k 0 0 12188 0 0:02:30 0:02:00 0:00:30 0
79 1786k 79 1428k 0 0 12087 0 0:02:31 0:02:01 0:00:30 0
79 1786k 79 1428k 0 0 11988 0 0:02:32 0:02:02 0:00:30 0
79 1786k 79 1428k 0 0 11891 0 0:02:33 0:02:03 0:00:30 0
79 1786k 79 1428k 0 0 11795 0 0:02:35 0:02:04 0:00:31 0
79 1786k 79 1428k 0 0 11700 0 0:02:36 0:02:05 0:00:31 0
79 1786k 79 1428k 0 0 11607 0 0:02:37 0:02:06 0:00:31 0
79 1786k 79 1428k 0 0 11516 0 0:02:38 0:02:07 0:00:31 0
79 1786k 79 1428k 0 0 11426 0 0:02:40 0:02:08 0:00:32 0
79 1786k 79 1428k 0 0 11337 0 0:02:41 0:02:09 0:00:32 0
79 1786k 79 1428k 0 0 11250 0 0:02:42 0:02:10 0:00:32 0
79 1786k 79 1428k 0 0 11164 0 0:02:43 0:02:11 0:00:32 0
79 1786k 79 1428k 0 0 11079 0 0:02:45 0:02:12 0:00:33 0
79 1786k 79 1428k 0 0 10996 0 0:02:46 0:02:13 0:00:33 0
79 1786k 79 1428k 0 0 10914 0 0:02:47 0:02:14 0:00:33 0
79 1786k 79 1428k 0 0 10833 0 0:02:48 0:02:15 0:00:33 0
79 1786k 79 1428k 0 0 10753 0 0:02:50 0:02:16 0:00:34 0
79 1786k 79 1428k 0 0 10675 0 0:02:51 0:02:17 0:00:34 0
79 1786k 79 1428k 0 0 10597 0 0:02:52 0:02:18 0:00:34 0
79 1786k 79 1428k 0 0 10521 0 0:02:53 0:02:19 0:00:34 0
79 1786k 79 1428k 0 0 10446 0 0:02:55 0:02:20 0:00:35 0
79 1786k 79 1428k 0 0 10371 0 0:02:56 0:02:21 0:00:35 0
79 1786k 79 1428k 0 0 10298 0 0:02:57 0:02:22 0:00:35 0
79 1786k 79 1428k 0 0 10226 0 0:02:58 0:02:23 0:00:35 0
79 1786k 79 1428k 0 0 10155 0 0:03:00 0:02:24 0:00:36 0
79 1786k 79 1428k 0 0 10085 0 0:03:01 0:02:25 0:00:36 0
79 1786k 79 1428k 0 0 10016 0 0:03:02 0:02:26 0:00:36 0
79 1786k 79 1428k 0 0 9948 0 0:03:03 0:02:27 0:00:36 0
79 1786k 79 1428k 0 0 9881 0 0:03:05 0:02:28 0:00:37 0
79 1786k 79 1428k 0 0 9814 0 0:03:06 0:02:29 0:00:37 0
79 1786k 79 1428k 0 0 9749 0 0:03:07 0:02:30 0:00:37 0
79 1786k 79 1428k 0 0 9684 0 0:03:08 0:02:31 0:00:37 0
79 1786k 79 1428k 0 0 9620 0 0:03:10 0:02:32 0:00:38 0
79 1786k 79 1428k 0 0 9557 0 0:03:11 0:02:33 0:00:38 0
79 1786k 79 1428k 0 0 9495 0 0:03:12 0:02:34 0:00:38 0
79 1786k 79 1428k 0 0 9434 0 0:03:13 0:02:35 0:00:38 0
79 1786k 79 1428k 0 0 9373 0 0:03:15 0:02:36 0:00:39 0
79 1786k 79 1428k 0 0 9314 0 0:03:16 0:02:37 0:00:39 0
79 1786k 79 1428k 0 0 9255 0 0:03:17 0:02:38 0:00:39 0
79 1786k 79 1428k 0 0 9196 0 0:03:18 0:02:39 0:00:39 0
79 1786k 79 1428k 0 0 9139 0 0:03:20 0:02:40 0:00:40 0
79 1786k 79 1428k 0 0 9082 0 0:03:21 0:02:41 0:00:40 0
79 1786k 79 1428k 0 0 9026 0 0:03:22 0:02:42 0:00:40 0
79 1786k 79 1428k 0 0 8971 0 0:03:23 0:02:43 0:00:40 0
79 1786k 79 1428k 0 0 8916 0 0:03:25 0:02:44 0:00:41 0
79 1786k 79 1428k 0 0 8862 0 0:03:26 0:02:45 0:00:41 0
79 1786k 79 1428k 0 0 8808 0 0:03:27 0:02:46 0:00:41 0
79 1786k 79 1428k 0 0 8756 0 0:03:28 0:02:47 0:00:41 0
79 1786k 79 1428k 0 0 8704 0 0:03:30 0:02:48 0:00:42 0
79 1786k 79 1428k 0 0 8652 0 0:03:31 0:02:49 0:00:42 0
79 1786k 79 1428k 0 0 8601 0 0:03:32 0:02:50 0:00:42 0
79 1786k 79 1428k 0 0 8551 0 0:03:33 0:02:51 0:00:42 0
79 1786k 79 1428k 0 0 8501 0 0:03:35 0:02:52 0:00:43 0
79 1786k 79 1428k 0 0 8452 0 0:03:36 0:02:53 0:00:43 0
79 1786k 79 1428k 0 0 8403 0 0:03:37 0:02:54 0:00:43 0
79 1786k 79 1428k 0 0 8355 0 0:03:39 0:02:55 0:00:44 0
79 1786k 79 1428k 0 0 8308 0 0:03:40 0:02:56 0:00:44 0
79 1786k 79 1428k 0 0 8261 0 0:03:41 0:02:57 0:00:44 0
79 1786k 79 1428k 0 0 8214 0 0:03:42 0:02:58 0:00:44 0
79 1786k 79 1428k 0 0 8168 0 0:03:44 0:02:59 0:00:45 0
79 1786k 79 1428k 0 0 8123 0 0:03:45 0:03:00 0:00:45 0
79 1786k 79 1428k 0 0 8078 0 0:03:46 0:03:01 0:00:45 0
79 1786k 79 1428k 0 0 8034 0 0:03:47 0:03:02 0:00:45 0
79 1786k 79 1428k 0 0 7990 0 0:03:49 0:03:03 0:00:46 0
79 1786k 79 1428k 0 0 7946 0 0:03:50 0:03:04 0:00:46 0
79 1786k 79 1428k 0 0 7903 0 0:03:51 0:03:05 0:00:46 0
79 1786k 79 1428k 0 0 7861 0 0:03:52 0:03:06 0:00:46 0
79 1786k 79 1428k 0 0 7819 0 0:03:54 0:03:07 0:00:47 0
79 1786k 79 1428k 0 0 7777 0 0:03:55 0:03:08 0:00:47 0
79 1786k 79 1428k 0 0 7736 0 0:03:56 0:03:09 0:00:47 0
79 1786k 79 1428k 0 0 7695 0 0:03:57 0:03:10 0:00:47 0
79 1786k 79 1428k 0 0 7655 0 0:03:59 0:03:11 0:00:48 0
79 1786k 79 1428k 0 0 7615 0 0:04:00 0:03:12 0:00:48 0
79 1786k 79 1428k 0 0 7575 0 0:04:01 0:03:13 0:00:48 0
79 1786k 79 1428k 0 0 7536 0 0:04:02 0:03:14 0:00:48 0
79 1786k 79 1428k 0 0 7498 0 0:04:04 0:03:15 0:00:49 0
79 1786k 79 1428k 0 0 7459 0 0:04:05 0:03:16 0:00:49 0
79 1786k 79 1428k 0 0 7422 0 0:04:06 0:03:17 0:00:49 0
79 1786k 79 1428k 0 0 7384 0 0:04:07 0:03:18 0:00:49 0
79 1786k 79 1428k 0 0 7347 0 0:04:09 0:03:19 0:00:50 0
79 1786k 79 1428k 0 0 7310 0 0:04:10 0:03:20 0:00:50 0
79 1786k 79 1428k 0 0 7274 0 0:04:11 0:03:21 0:00:50 0
79 1786k 79 1428k 0 0 7238 0 0:04:12 0:03:22 0:00:50 0
79 1786k 79 1428k 0 0 7202 0 0:04:14 0:03:23 0:00:51 0
79 1786k 79 1428k 0 0 7167 0 0:04:15 0:03:24 0:00:51 0
79 1786k 79 1428k 0 0 7132 0 0:04:16 0:03:25 0:00:51 0
79 1786k 79 1428k 0 0 7097 0 0:04:17 0:03:26 0:00:51 0
79 1786k 79 1428k 0 0 7079 0 0:04:18 0:03:26 0:00:52 0
curl: (56) SSL read: error:00000000:lib(0):func(0):reason(0), errno 104
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 27, 2015, 7:48 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 7:48 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78109
-----------------------------------------------------------
@ReviewBot retry
- Kevin Sweeney
On March 27, 2015, 12:48 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 12:48 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78549
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On March 27, 2015, 8:50 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 8:50 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/python/apache/aurora/client/hooks/BUILD 49d73dfddbcee97ddde1a483f6697865d2566508
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/python/apache/aurora/client/hooks/BUILD 43f59bc5a2397ad851211e064d83ef6e6de81972
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78113
-----------------------------------------------------------
Ship it!
Master (45f2a84) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 27, 2015, 8:50 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 8:50 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/python/apache/aurora/client/hooks/BUILD 49d73dfddbcee97ddde1a483f6697865d2566508
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/python/apache/aurora/client/hooks/BUILD 43f59bc5a2397ad851211e064d83ef6e6de81972
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78834
-----------------------------------------------------------
This patch does not apply cleanly on master (05d75e5), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 3, 2015, 9:19 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 9:19 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78958
-----------------------------------------------------------
Ship it!
Master (27a602d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 6, 2015, 5:56 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 5:56 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java 1f773cab5100e960867b886d58fde963041be535
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review79427
-----------------------------------------------------------
Ping, wfarner
- Kevin Sweeney
On April 6, 2015, 10:56 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 10:56 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java 1f773cab5100e960867b886d58fde963041be535
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/
-----------------------------------------------------------
(Updated April 9, 2015, 11:44 a.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Improve test.
Bugs: AURORA-812
https://issues.apache.org/jira/browse/AURORA-812
Repository: aurora
Description
-------
Support authenticating to the scheduler API with Kerberos.
Diffs (updated)
-----
config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99
examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java 1f773cab5100e960867b886d58fde963041be535
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
Diff: https://reviews.apache.org/r/32559/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review79468
-----------------------------------------------------------
Ship it!
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java
<https://reviews.apache.org/r/32559/#comment128865>
Do you care about the return value here?
- Bill Farner
On April 6, 2015, 5:56 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated April 6, 2015, 5:56 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java 1f773cab5100e960867b886d58fde963041be535
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/
-----------------------------------------------------------
(Updated April 6, 2015, 10:56 a.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
rebase patch
Bugs: AURORA-812
https://issues.apache.org/jira/browse/AURORA-812
Repository: aurora
Description
-------
Support authenticating to the scheduler API with Kerberos.
Diffs (updated)
-----
config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99
examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java 1f773cab5100e960867b886d58fde963041be535
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
Diff: https://reviews.apache.org/r/32559/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/
-----------------------------------------------------------
(Updated April 3, 2015, 2:19 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
Bill's feedback.
Bugs: AURORA-812
https://issues.apache.org/jira/browse/AURORA-812
Repository: aurora
Description
-------
Support authenticating to the scheduler API with Kerberos.
Diffs (updated)
-----
config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99
examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
Diff: https://reviews.apache.org/r/32559/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Bill Farner <wf...@apache.org>.
> On April 2, 2015, 5:23 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, lines 182-186
> > <https://reviews.apache.org/r/32559/diff/4/?file=908318#file908318line182>
> >
> > Why is this in a `finally`? Seems like any exception is fatal, and there's no more work to do. Use of a finally block makes the expectations of this code confusing.
>
> Kevin Sweeney wrote:
> I'm patching a global system property and unpatching it when I leave this block since it's not my resource to manage. This is similar to using a contextmanager in python - the effect of the property change shouldn't be visible once we've left this code block no matter how we left it
Ah, i missed that.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78608
-----------------------------------------------------------
On April 3, 2015, 9:19 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 9:19 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh, line 1
> > <https://reviews.apache.org/r/32559/diff/4/?file=908329#file908329line1>
> >
> > Please invoke this from the existing end-to-end test script to avoid another qualification step for developers.
>
> Kevin Sweeney wrote:
> Done, but that script appears to be broken on master.
This was transient - the script works. Reviewers please validate that the e2e test passes in your environ,ent.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78608
-----------------------------------------------------------
On March 27, 2015, 1:50 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 1:50 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/python/apache/aurora/client/hooks/BUILD 49d73dfddbcee97ddde1a483f6697865d2566508
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/python/apache/aurora/client/hooks/BUILD 43f59bc5a2397ad851211e064d83ef6e6de81972
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java, line 46
> > <https://reviews.apache.org/r/32559/diff/4/?file=908315#file908315line46>
> >
> > What does this mean? Perhaps the missing context is "<other component x> will do this part".
Reworded.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java, line 53
> > <https://reviews.apache.org/r/32559/diff/4/?file=908315#file908315line53>
> >
> > Marking this method as deprecated is slightly confusing. I assume it's only because you don't want other code in the project to call it? If that's the case, i suggest you don't use deprecated as the signal and instead docs + code review.
Done. I was attempting to follow the guava convention that uses this to bring attention to potential errors with this annotation, but will not overload its use here.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java, line 34
> > <https://reviews.apache.org/r/32559/diff/4/?file=908316#file908316line34>
> >
> > `<p>`
Fixed.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java, line 35
> > <https://reviews.apache.org/r/32559/diff/4/?file=908316#file908316line35>
> >
> > "it" is ambiguous. Consider rewording: "Another filter may still be used for authentication, in which case the ini file can still be used to provide authorization configuration."
done.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java, line 36
> > <https://reviews.apache.org/r/32559/diff/4/?file=908317#file908317line36>
> >
> > comment formatting is off
fixed.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java, line 46
> > <https://reviews.apache.org/r/32559/diff/4/?file=908317#file908317line46>
> >
> > nonNull?
fixed.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, lines 56-57
> > <https://reviews.apache.org/r/32559/diff/4/?file=908318#file908318line56>
> >
> > These are pure magic to me. Please doc.
Doc'd.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, lines 114-115
> > <https://reviews.apache.org/r/32559/diff/4/?file=908318#file908318line114>
> >
> > This is a question of convention - what's the upside to addError/return as opposed to throwing?
addError lets you get a bunch of errors at once whereas throwing aborts injector creation.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, line 113
> > <https://reviews.apache.org/r/32559/diff/4/?file=908318#file908318line113>
> >
> > Why is this `Optional` if it's required? Ditto below.
The command-line argument is nullable (can't use constraints since that would make them required even if you weren't using Kerberos). The alternative is doing requireNonNull in the constructor, which will produce a worse error message than the one below. Optional was chosen over a null check to be explicit.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, line 147
> > <https://reviews.apache.org/r/32559/diff/4/?file=908318#file908318line147>
> >
> > s/jass/jaas/
fixed.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, lines 124-141
> > <https://reviews.apache.org/r/32559/diff/4/?file=908318#file908318line124>
> >
> > Given the behavior i see, i'd prefer a constant and String.format over the resource file and use of StringTemplate.
> >
> > If there are reasons for retaining this complexity, please leave a comment justifying it.
Ok dropped.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, lines 182-186
> > <https://reviews.apache.org/r/32559/diff/4/?file=908318#file908318line182>
> >
> > Why is this in a `finally`? Seems like any exception is fatal, and there's no more work to do. Use of a finally block makes the expectations of this code confusing.
I'm patching a global system property and unpatching it when I leave this block since it's not my resource to manage. This is similar to using a contextmanager in python - the effect of the property change shouldn't be visible once we've left this code block no matter how we left it
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java, line 200
> > <https://reviews.apache.org/r/32559/diff/4/?file=908318#file908318line200>
> >
> > remove newline
done.
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java, line 75
> > <https://reviews.apache.org/r/32559/diff/4/?file=908320#file908320line75>
> >
> > Please use a consistent exception logging convention - the exception logged on :67 is different.
made consistent
> On April 2, 2015, 10:23 a.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh, line 1
> > <https://reviews.apache.org/r/32559/diff/4/?file=908329#file908329line1>
> >
> > Please invoke this from the existing end-to-end test script to avoid another qualification step for developers.
Done, but that script appears to be broken on master.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78608
-----------------------------------------------------------
On March 27, 2015, 1:50 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 1:50 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/python/apache/aurora/client/hooks/BUILD 49d73dfddbcee97ddde1a483f6697865d2566508
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/python/apache/aurora/client/hooks/BUILD 43f59bc5a2397ad851211e064d83ef6e6de81972
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Bill Farner <wf...@apache.org>.
> On April 2, 2015, 5:23 p.m., Bill Farner wrote:
> > src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh, line 1
> > <https://reviews.apache.org/r/32559/diff/4/?file=908329#file908329line1>
> >
> > Please invoke this from the existing end-to-end test script to avoid another qualification step for developers.
>
> Kevin Sweeney wrote:
> Done, but that script appears to be broken on master.
>
> Kevin Sweeney wrote:
> This was transient - the script works. Reviewers please validate that the e2e test passes in your environ,ent.
Can you rebase? I'm getting a conflict in `ApiSecurityModule`.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78608
-----------------------------------------------------------
On April 3, 2015, 9:19 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated April 3, 2015, 9:19 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh 0fbbfdc049abea47ee5e92acd6c8c96523ba0a99
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 74b22f6226cd9de0cac0879bfdb102b3f780bc6e
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78608
-----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java
<https://reviews.apache.org/r/32559/#comment127514>
What does this mean? Perhaps the missing context is "<other component x> will do this part".
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java
<https://reviews.apache.org/r/32559/#comment127515>
Marking this method as deprecated is slightly confusing. I assume it's only because you don't want other code in the project to call it? If that's the case, i suggest you don't use deprecated as the signal and instead docs + code review.
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment127516>
`<p>`
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment127517>
"it" is ambiguous. Consider rewording: "Another filter may still be used for authentication, in which case the ini file can still be used to provide authorization configuration."
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java
<https://reviews.apache.org/r/32559/#comment127518>
comment formatting is off
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java
<https://reviews.apache.org/r/32559/#comment127521>
nonNull?
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment127525>
These are pure magic to me. Please doc.
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment127524>
Why is this `Optional` if it's required? Ditto below.
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment127589>
This is a question of convention - what's the upside to addError/return as opposed to throwing?
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment127597>
Given the behavior i see, i'd prefer a constant and String.format over the resource file and use of StringTemplate.
If there are reasons for retaining this complexity, please leave a comment justifying it.
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment127606>
s/jass/jaas/
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment127610>
Why is this in a `finally`? Seems like any exception is fatal, and there's no more work to do. Use of a finally block makes the expectations of this code confusing.
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
<https://reviews.apache.org/r/32559/#comment127526>
remove newline
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java
<https://reviews.apache.org/r/32559/#comment127617>
Please use a consistent exception logging convention - the exception logged on :67 is different.
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh
<https://reviews.apache.org/r/32559/#comment127627>
Please invoke this from the existing end-to-end test script to avoid another qualification step for developers.
- Bill Farner
On March 27, 2015, 8:50 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 8:50 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/python/apache/aurora/client/hooks/BUILD 49d73dfddbcee97ddde1a483f6697865d2566508
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/python/apache/aurora/client/hooks/BUILD 43f59bc5a2397ad851211e064d83ef6e6de81972
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/
-----------------------------------------------------------
(Updated March 27, 2015, 1:50 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
* Add -kerberos_debug flag
* Remove aurora-scheduler-kerberos.conf in tear_down
Bugs: AURORA-812
https://issues.apache.org/jira/browse/AURORA-812
Repository: aurora
Description
-------
Support authenticating to the scheduler API with Kerberos.
Diffs (updated)
-----
config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
src/main/python/apache/aurora/client/hooks/BUILD 49d73dfddbcee97ddde1a483f6697865d2566508
src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
src/test/python/apache/aurora/client/hooks/BUILD 43f59bc5a2397ad851211e064d83ef6e6de81972
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
Diff: https://reviews.apache.org/r/32559/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78107
-----------------------------------------------------------
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh
<https://reviews.apache.org/r/32559/#comment126557>
Should we just do this in vagrant provisioning? Or should we remove it on exit? It feels weird for the test to leave it behind.
- Joshua Cohen
On March 27, 2015, 7:48 p.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 7:48 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/
-----------------------------------------------------------
(Updated March 27, 2015, 12:48 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
jcohen's feedback.
Bugs: AURORA-812
https://issues.apache.org/jira/browse/AURORA-812
Repository: aurora
Description
-------
Support authenticating to the scheduler API with Kerberos.
Diffs (updated)
-----
config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
Diff: https://reviews.apache.org/r/32559/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78006
-----------------------------------------------------------
Ship it!
Master (45f2a84) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 27, 2015, 1:23 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 1:23 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/
-----------------------------------------------------------
(Updated March 26, 2015, 6:23 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Changes
-------
rebase
Bugs: AURORA-812
https://issues.apache.org/jira/browse/AURORA-812
Repository: aurora
Description
-------
Support authenticating to the scheduler API with Kerberos.
Diffs (updated)
-----
config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
Diff: https://reviews.apache.org/r/32559/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/#review78003
-----------------------------------------------------------
This patch does not apply cleanly on master (45f2a84), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 27, 2015, 1:13 a.m., Kevin Sweeney wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32559/
> -----------------------------------------------------------
>
> (Updated March 27, 2015, 1:13 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Bill Farner.
>
>
> Bugs: AURORA-812
> https://issues.apache.org/jira/browse/AURORA-812
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Support authenticating to the scheduler API with Kerberos.
>
>
> Diffs
> -----
>
> config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
> examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
> examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
> src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
> src/main/python/apache/aurora/client/hooks/BUILD 49d73dfddbcee97ddde1a483f6697865d2566508
> src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
> src/test/python/apache/aurora/client/hooks/BUILD 43f59bc5a2397ad851211e064d83ef6e6de81972
> src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32559/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
>
>
> Thanks,
>
> Kevin Sweeney
>
>
Re: Review Request 32559: Add Kerberos support to the scheduler
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32559/
-----------------------------------------------------------
(Updated March 26, 2015, 6:13 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-812
https://issues.apache.org/jira/browse/AURORA-812
Repository: aurora
Description
-------
Support authenticating to the scheduler API with Kerberos.
Diffs
-----
config/findbugs/excludeFilter.xml 5ff5f87d6bb7d8bf3d9ecb1bc6c6b1a524d1bf15
examples/vagrant/provision-dev-cluster.sh ae500436e703140065e5c16fc0e38dbe3214e69f
examples/vagrant/upstart/aurora-scheduler-kerberos.conf PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java ec6a02c4086ee0d5a7529083030d978ea889f677
src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderToken.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java 58b559e96402ef282dc0e5ac2de0930906256487
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5Realm.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParser.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java PRE-CREATION
src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroUtils.java PRE-CREATION
src/main/python/apache/aurora/client/hooks/BUILD 49d73dfddbcee97ddde1a483f6697865d2566508
src/main/resources/org/apache/aurora/scheduler/http/api/security/jaas.conf.st PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/AuthorizeHeaderTokenTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModuleTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/KerberosPrincipalParserTest.java PRE-CREATION
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java PRE-CREATION
src/test/python/apache/aurora/client/hooks/BUILD 43f59bc5a2397ad851211e064d83ef6e6de81972
src/test/sh/org/apache/aurora/e2e/test_kerberos_end_to_end.sh PRE-CREATION
Diff: https://reviews.apache.org/r/32559/diff/
Testing
-------
./gradlew -Pq build
./src/test/sh/org/apache/aurora/test_kerberos_end_to_end.sh
Thanks,
Kevin Sweeney