You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/06/09 05:14:53 UTC

[kudu-CR] Convert alter table-test to use RaftConsensus

Hello David Ribeiro Alves,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/3347

to review the following change.

Change subject: Convert alter_table-test to use RaftConsensus
......................................................................

Convert alter_table-test to use RaftConsensus

1. Wait for tablet to be elected leader before proceeding.
2. All of the timestamps must be incremented due to the initial no-op
   written to the WAL by the Raft leader.

Change-Id: I6c6cc01689554b1aabe92d8c98661275082bede6
---
M src/kudu/integration-tests/alter_table-test.cc
1 file changed, 5 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/3347/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c6cc01689554b1aabe92d8c98661275082bede6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>

[kudu-CR] Convert alter table-test to use RaftConsensus

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Convert alter_table-test to use RaftConsensus
......................................................................


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/1791/

-- 
To view, visit http://gerrit.cloudera.org:8080/3347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6cc01689554b1aabe92d8c98661275082bede6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Convert alter table-test to use RaftConsensus

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.

Change subject: Convert alter_table-test to use RaftConsensus
......................................................................


Abandoned

squashing this. hard to do it separate

-- 
To view, visit http://gerrit.cloudera.org:8080/3347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I6c6cc01689554b1aabe92d8c98661275082bede6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Convert alter table-test to use RaftConsensus

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.

Change subject: Convert alter_table-test to use RaftConsensus
......................................................................


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/1800/

-- 
To view, visit http://gerrit.cloudera.org:8080/3347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c6cc01689554b1aabe92d8c98661275082bede6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No