You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/20 05:47:00 UTC

[jira] [Work logged] (BEAM-8740) TestPubsub ignores timeout

     [ https://issues.apache.org/jira/browse/BEAM-8740?focusedWorklogId=346474&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-346474 ]

ASF GitHub Bot logged work on BEAM-8740:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Nov/19 05:46
            Start Date: 20/Nov/19 05:46
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on pull request #10153: [BEAM-8740] TestPubsub ignores timeout
URL: https://github.com/apache/beam/pull/10153#discussion_r348300443
 
 

 ##########
 File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsub.java
 ##########
 @@ -225,7 +227,7 @@ public void publish(List<PubsubMessage> messages) throws IOException {
     receivedMessages.addAll(pull(n - receivedMessages.size()));
 
     while (receivedMessages.size() < n
-        && Seconds.secondsBetween(new DateTime(), startTime).getSeconds() < timeoutSeconds) {
+        && Seconds.secondsBetween(startTime, new DateTime()).getSeconds() < timeoutSeconds) {
 
 Review comment:
   ouch
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 346474)
    Remaining Estimate: 0h
            Time Spent: 10m

> TestPubsub ignores timeout
> --------------------------
>
>                 Key: BEAM-8740
>                 URL: https://issues.apache.org/jira/browse/BEAM-8740
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>            Reporter: Brian Hulette
>            Assignee: Brian Hulette
>            Priority: Major
>             Fix For: 2.18.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)