[hbase] branch branch-2.3 updated: HBASE-25435 Slow metric value can be configured

[wa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wangzheng pushed a commit to branch branch-2.3
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/branch-2.3 by this push:
     new 9172dd0  HBASE-25435 Slow metric value can be configured
9172dd0 is described below

commit 9172dd084e93c8b299859d8cbecdba1586c1c7df
Author: leyangyueshan <15...@163.com>
AuthorDate: Thu Dec 31 22:37:31 2020 +0800

    HBASE-25435 Slow metric value can be configured
    
    Signed-off-by: jediwang <je...@tencent.com>
---
 .../hadoop/hbase/regionserver/MetricsRegionServer.java     | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
index f393853..a2781e6 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServer.java
@@ -44,6 +44,7 @@ public class MetricsRegionServer {
       "hbase.regionserver.enable.table.latencies";
   public static final boolean RS_ENABLE_TABLE_METRICS_DEFAULT = true;
 
+  public static final String SLOW_METRIC_TIME = "hbase.ipc.slow.metric.time";
   private final MetricsRegionServerSource serverSource;
   private final MetricsRegionServerWrapper regionServerWrapper;
   private RegionServerTableMetrics tableMetrics;
@@ -55,6 +56,8 @@ public class MetricsRegionServer {
   private Timer bulkLoadTimer;
   private Meter serverReadQueryMeter;
   private Meter serverWriteQueryMeter;
+  protected long slowMetricTime;
+  protected static final int DEFAULT_SLOW_METRIC_TIME = 1000; // milliseconds
 
   public MetricsRegionServer(MetricsRegionServerWrapper regionServerWrapper, Configuration conf,
       MetricsTable metricsTable) {
@@ -70,6 +73,7 @@ public class MetricsRegionServer {
     // create and use metrics from the new hbase-metrics based registry.
     bulkLoadTimer = metricRegistry.timer("Bulkload");
 
+    slowMetricTime = conf.getLong(SLOW_METRIC_TIME, DEFAULT_SLOW_METRIC_TIME);
     serverReadQueryMeter = metricRegistry.meter("ServerReadQueryPerSecond");
     serverWriteQueryMeter = metricRegistry.meter("ServerWriteQueryPerSecond");
     quotaSource = CompatibilitySingletonFactory.getInstance(MetricsRegionServerQuotaSource.class);
@@ -113,7 +117,7 @@ public class MetricsRegionServer {
     if (tableMetrics != null && tn != null) {
       tableMetrics.updatePutBatch(tn, t);
     }
-    if (t > 1000) {
+    if (t > slowMetricTime) {
       serverSource.incrSlowPut();
     }
     serverSource.updatePutBatch(t);
@@ -139,7 +143,7 @@ public class MetricsRegionServer {
     if (tableMetrics != null && tn != null) {
       tableMetrics.updateDeleteBatch(tn, t);
     }
-    if (t > 1000) {
+    if (t > slowMetricTime) {
       serverSource.incrSlowDelete();
     }
     serverSource.updateDeleteBatch(t);
@@ -163,7 +167,7 @@ public class MetricsRegionServer {
     if (tableMetrics != null && tn != null) {
       tableMetrics.updateGet(tn, t);
     }
-    if (t > 1000) {
+    if (t > slowMetricTime) {
       serverSource.incrSlowGet();
     }
     serverSource.updateGet(t);
@@ -174,7 +178,7 @@ public class MetricsRegionServer {
     if (tableMetrics != null && tn != null) {
       tableMetrics.updateIncrement(tn, t);
     }
-    if (t > 1000) {
+    if (t > slowMetricTime) {
       serverSource.incrSlowIncrement();
     }
     serverSource.updateIncrement(t);
@@ -185,7 +189,7 @@ public class MetricsRegionServer {
     if (tableMetrics != null && tn != null) {
       tableMetrics.updateAppend(tn, t);
     }
-    if (t > 1000) {
+    if (t > slowMetricTime) {
       serverSource.incrSlowAppend();
     }
     serverSource.updateAppend(t);