You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2015/09/18 01:19:11 UTC
Re: Review Request 37661: Add describe,
show and explain select tests for column level privileges
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37661/#review98967
-----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java (line 66)
<https://reviews.apache.org/r/37661/#comment155904>
Comment on how the test data looks like
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java (line 98)
<https://reviews.apache.org/r/37661/#comment155908>
Comment on what validation is performed.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java (line 169)
<https://reviews.apache.org/r/37661/#comment155727>
It is unclear that this function runs everything as user1. May be send the user name as a parameter? Or comment that it is being run as a user with privileges on subset of columns.
show table extended should require table level privileges.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java (line 179)
<https://reviews.apache.org/r/37661/#comment155732>
Show columns filters out unprivileged columns
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java (line 189)
<https://reviews.apache.org/r/37661/#comment155734>
See Sentry-881: basic describe returns alls columns. Whereas, formatted/extended is restricted for table level users.
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java (line 256)
<https://reviews.apache.org/r/37661/#comment155738>
newcol?
- Sravya Tirukkovalur
On Aug. 26, 2015, 10:07 p.m., Anne Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37661/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2015, 10:07 p.m.)
>
>
> Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
>
>
> Bugs: SENTRY-742
> https://issues.apache.org/jira/browse/SENTRY-742
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add a couple of test cases to cover column level privileges when user do DESCRIBE, SHOW AND EXPLAIN SELECT cases.
>
>
> Diffs
> -----
>
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java PRE-CREATION
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java cee05a0
>
> Diff: https://reviews.apache.org/r/37661/diff/
>
>
> Testing
> -------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 17.789 sec - in org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps
>
> Results :
>
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 6
>
>
> Thanks,
>
> Anne Yu
>
>