You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/24 02:35:41 UTC
[GitHub] [shardingsphere] Pace2Car commented on a diff in pull request #22364: Improve DistSQL DROP DB_DISCOVERY RULE
Pace2Car commented on code in PR #22364:
URL: https://github.com/apache/shardingsphere/pull/22364#discussion_r1031005322
##########
features/db-discovery/distsql/handler/src/test/java/org/apache/shardingsphere/dbdiscovery/distsql/handler/update/DropDatabaseDiscoveryRuleStatementUpdaterTest.java:
##########
@@ -136,8 +138,10 @@ private DropDatabaseDiscoveryRuleStatement createSQLStatementWithIfExists() {
private DatabaseDiscoveryRuleConfiguration createCurrentRuleConfiguration() {
DatabaseDiscoveryDataSourceRuleConfiguration dataSourceRuleConfig = new DatabaseDiscoveryDataSourceRuleConfiguration("ha_group", Collections.emptyList(), "ha_heartbeat", "readwrite_ds_MGR");
- Map<String, AlgorithmConfiguration> discoveryTypes = Collections.singletonMap(
- "readwrite_ds_MGR", new AlgorithmConfiguration("readwrite_ds_MGR", new Properties()));
+ Map<String, AlgorithmConfiguration> discoveryTypes = new LinkedHashMap<>(1, 1);
+ discoveryTypes.put("readwrite_ds_MGR", new AlgorithmConfiguration("readwrite_ds_MGR", new Properties()));
+ Map<String, DatabaseDiscoveryHeartBeatConfiguration> discoveryHeartbeats = new LinkedHashMap<>(1, 1);
+ discoveryTypes.put("unused_heartbeat", new AlgorithmConfiguration("heartbeat", new Properties()));
Review Comment:
Thank you for your correction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org