You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2016/10/26 15:08:56 UTC
[3/4] isis git commit: Fix DateTime marshalling in
JodaLocalDateValueSemanticsProvider
Fix DateTime marshalling in JodaLocalDateValueSemanticsProvider
This implementation of JodaLocalDateTimeValueSemanticsProvider,
given that
```
encodingFormatter = ISODateTimeFormat.basicDateTime()
```
assumes that
```
date == encodingFormatter.parseLocalDateTime(
encodingFormatter.print(date)
)
```
which is not true (at least for the latest ver. 2.9.4 of joda-time).
Provided solution confirms with Java 8 java.time.format.DateTimeFormatter.ISO_LOCAL_DATE_TIME which uses yyyy-MM-dd'T'HH:mm:ss
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/d038b2d4
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/d038b2d4
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/d038b2d4
Branch: refs/heads/maint-1.13.1
Commit: d038b2d4126c499257c8c263afcb3baf6dc9925b
Parents: bb0c6ab
Author: Andi Huber <ho...@gmx.at>
Authored: Mon Oct 3 09:38:04 2016 +0200
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Wed Oct 26 15:39:18 2016 +0100
----------------------------------------------------------------------
.../datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/d038b2d4/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java
----------------------------------------------------------------------
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java
index 4c84b75..439a224 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/value/datetimejodalocal/JodaLocalDateTimeValueSemanticsProvider.java
@@ -126,7 +126,7 @@ public class JodaLocalDateTimeValueSemanticsProvider extends ValueSemanticsProvi
private static final LocalDateTime DEFAULT_VALUE = null;
- private final DateTimeFormatter encodingFormatter = ISODateTimeFormat.basicDateTime();
+ private final DateTimeFormatter encodingFormatter = ISODateTimeFormat.dateHourMinuteSecond();
private DateTimeFormatter titleStringFormatter;
private String titleStringFormatNameOrPattern;