[GitHub] emilianbold commented on a change in pull request #295: Drop usage of FileInput/OutputStreams - modules a* -> c*

[GitBox <gi...@apache.org>]

emilianbold commented on a change in pull request #295: Drop usage of FileInput/OutputStreams - modules a* -> c*
URL: https://github.com/apache/incubator-netbeans/pull/295#discussion_r153083614
 
 

 ##########
 File path: autoupdate.services/libsrc/org/netbeans/updater/UpdaterInternal.java
 ##########
 @@ -99,28 +98,12 @@ private void firePropertyChange(String name, Object oldV, Object newV) {
             }
 
             @Override
-            public OutputStream createOS(final File file) throws FileNotFoundException {
+            public OutputStream createOS(final File file) throws IOException {
                 if (modified.get(file) == null) {
                     modified.put(file, file.lastModified());
                 }
                 XMLUtil.LOG.log(Level.FINE, "Creating output stream for {0}", file);
-                return new FileOutputStream(file) {
-                    boolean closed;
-                    
-                    @Override
-                    public void close() throws IOException {
-                        if (closed) {
-                            return;
-                        }
-                        closed = true;
-                        XMLUtil.LOG.log(Level.FINE, "Closing output stream for {0}", file);
-                        super.close();
-                        XMLUtil.LOG.log(
-                            Level.INFO, "File installed {0}@{1}", 
 
 Review comment:
   This logger here seems useful.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services