You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/06/14 12:45:01 UTC
[jira] [Commented] (TAJO-1968) Change 'threshold' in the name of
configuration and session variables to 'limit'
[ https://issues.apache.org/jira/browse/TAJO-1968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329430#comment-15329430 ]
ASF GitHub Bot commented on TAJO-1968:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/1030#discussion_r66961865
--- Diff: tajo-common/src/main/java/org/apache/tajo/SessionVars.java ---
@@ -94,10 +94,10 @@
Validators.bool()),
// for distributed query strategies
- BROADCAST_NON_CROSS_JOIN_THRESHOLD(ConfVars.$DIST_QUERY_BROADCAST_NON_CROSS_JOIN_THRESHOLD,
+ BROADCAST_NON_CROSS_JOIN_THRESHOLD(ConfVars.$DIST_QUERY_BROADCAST_NON_CROSS_JOIN_LIMIT,
"restriction for the total size of broadcasted table for non-cross join (kb)", DEFAULT, Long.class,
Validators.min("0")),
- BROADCAST_CROSS_JOIN_THRESHOLD(ConfVars.$DIST_QUERY_BROADCAST_CROSS_JOIN_THRESHOLD,
+ BROADCAST_CROSS_JOIN_THRESHOLD(ConfVars.$DIST_QUERY_BROADCAST_CROSS_JOIN_LIMIT,
--- End diff --
The name of the above two session variables also need to be changed.
> Change 'threshold' in the name of configuration and session variables to 'limit'
> --------------------------------------------------------------------------------
>
> Key: TAJO-1968
> URL: https://issues.apache.org/jira/browse/TAJO-1968
> Project: Tajo
> Issue Type: Task
> Components: conf and scripts
> Reporter: Jihoon Son
> Assignee: Byunghoon Lim
> Priority: Minor
> Labels: newbie
> Fix For: 0.12.0
>
>
> See the discussion at https://github.com/apache/tajo/pull/848#discussion_r44101976.
> We need to make the configuration names consistent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)