[GitHub] [incubator-yunikorn-k8shim] HuangTing-Yao commented on a change in pull request #252: [YUNIKORN-628]Publish a pod event to indicate the task is being gang scheduling

[GitBox <gi...@apache.org>]

HuangTing-Yao commented on a change in pull request #252:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/252#discussion_r611147332



##########
File path: pkg/cache/task.go
##########
@@ -265,6 +265,12 @@ func (task *Task) handleSubmitTaskEvent(event *fsm.Event) {
 
 	events.GetRecorder().Eventf(task.pod, v1.EventTypeNormal, "Scheduling",
 		"%s is queued and waiting for allocation", task.alias)
+	// if this task is belong to the gang member, then post a message to indicate the pod will being scheduled as gang member

Review comment:
       OK,Sure

##########
File path: pkg/cache/task_test.go
##########
@@ -28,13 +29,21 @@ import (
 	"k8s.io/apimachinery/pkg/api/resource"
 	apis "k8s.io/apimachinery/pkg/apis/meta/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/client-go/tools/record"
 
 	"github.com/apache/incubator-yunikorn-core/pkg/common"
 	"github.com/apache/incubator-yunikorn-k8shim/pkg/client"
+	"github.com/apache/incubator-yunikorn-k8shim/pkg/common/constants"
 	"github.com/apache/incubator-yunikorn-k8shim/pkg/common/events"
+	"github.com/apache/incubator-yunikorn-k8shim/pkg/conf"
 	"github.com/apache/incubator-yunikorn-scheduler-interface/lib/go/si"
 )
 
+// type recorderTime struct {
+// 	time int64
+// 	lock *sync.RWMutex
+// }
+

Review comment:
       OK.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org