You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/02/20 00:36:52 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4416: Upgrade
Traffic Router to use Traffic Ops API 2.0
ocket8888 opened a new pull request #4416: Upgrade Traffic Router to use Traffic Ops API 2.0
URL: https://github.com/apache/trafficcontrol/pull/4416
## What does this PR (Pull Request) do?
- [x] This PR is not related to any Issue
Upgrades Traffic Router to use Traffic Ops API v2.0 - it still uses `/internal`-based endpoints, though.
## Which Traffic Control components are affected by this PR?
- Traffic Router
## What is the best way to verify this PR?
Run the existing unit and integration tests - mine were passing up to the point that it needed to connect to Traffic Monitor because I didn't know how to configure it. But that part shouldn't be affected.
## The following criteria are ALL met by this PR
- [x] Tests are unchanged because intended behavior is unchanged
- [x] Documentation unchanged because intended behavior is unchanged
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rawlinp commented on issue #4416: Upgrade Traffic
Router to use Traffic Ops API 2.0
Posted by GitBox <gi...@apache.org>.
rawlinp commented on issue #4416: Upgrade Traffic Router to use Traffic Ops API 2.0
URL: https://github.com/apache/trafficcontrol/pull/4416#issuecomment-588579281
Changes look good, and TR tests pass. But you made the weasel angry:
```
Error Unknown! traffic_router/core/src/test/resources/api/2.0/cdns/name/thecdn/sslkeys
Error Unknown! traffic_router/core/src/test/resources/api/2.0/cdns/name/thecdn/sslkeys-missing-1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] ocket8888 commented on issue #4416: Upgrade
Traffic Router to use Traffic Ops API 2.0
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on issue #4416: Upgrade Traffic Router to use Traffic Ops API 2.0
URL: https://github.com/apache/trafficcontrol/pull/4416#issuecomment-588612042
ohh, I didn't think of that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [trafficcontrol] rawlinp merged pull request #4416: Upgrade Traffic
Router to use Traffic Ops API 2.0
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #4416: Upgrade Traffic Router to use Traffic Ops API 2.0
URL: https://github.com/apache/trafficcontrol/pull/4416
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services