[jira] Commented: (CHUKWA-268) Create an interface to manage all Adaptors

["Eric Yang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CHUKWA-268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12717483#action_12717483 ] 

Eric Yang commented on CHUKWA-268:
----------------------------------


processAddCommand("add org.apache.hadoop.chukwa.datacollection.adaptor.ExecAdaptor ps ps aux 0");

The processCommand used to support multiple type of commands.  If the interface is changing to processAddCommand, perhaps, we don't need add as part of the string.

Could we refine the adaptor interface to?

stopAdaptor(param, GRACEFUL|FORCED)
listAdaptor(param)
startAdaptor(param)

processCommand("add param");
processCommand("list");
processCommand("shutdown param");
processCommand("stop param");



> Create an interface to manage all Adaptors
> ------------------------------------------
>
>                 Key: CHUKWA-268
>                 URL: https://issues.apache.org/jira/browse/CHUKWA-268
>             Project: Hadoop Chukwa
>          Issue Type: Improvement
>          Components: data collection
>    Affects Versions: 0.2.0
>            Reporter: Jerome Boulon
>            Assignee: Ari Rabkin
>             Fix For: 0.2.0
>
>         Attachments: CHUKWA-268.patch
>
>
> Currently the agent manage all adaptors and it's fine however it will be cleaner to have an AdaptorManager interface. The agent will just implement this interface without changing anything, but adaptors will retrieve the manager using ChukwaFactory. This will remove the hard dependency between Agent and adaptors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.