You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/23 11:39:31 UTC
[GitHub] [nifi] Wastack opened a new pull request #4356: NIFI-7576 ListenHTTP: Honor primary node only attribute
Wastack opened a new pull request #4356:
URL: https://github.com/apache/nifi/pull/4356
ListenHTTP processor now binds port and creates a HTTP connection only
if one of the following conditions apply:
- Primary node execution is 'false'
- Primary node execution is 'true' and node is elected as primary node.
Changes:
- Connection is established in 'onTrigger' annotated method instead of
'onSchedule'. (This is similar to how handleHTTPRequest processor
handles connections.)
- 'onPrimaryNodeStateChange' annotated method is introduced to tear down
server on reelection of primary node
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #4356: NIFI-7576 ListenHTTP: Honor primary node only attribute
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #4356:
URL: https://github.com/apache/nifi/pull/4356#discussion_r444222483
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
##########
@@ -373,6 +386,14 @@ public void createHttpServer(final ProcessContext context) throws Exception {
@Override
public void onTrigger(final ProcessContext context, final ProcessSessionFactory sessionFactory) {
+ try {
+ if (!initialized.get()) {
Review comment:
If the processor is scheduled with multiple threads, we could have multiple threads entering `createHttpServerFromService` simultaneously. Each can then create a new server, resulting in multiple Jetty Servers being created and started but only one ever getting stored as `this.server` so we'd be leaking the server resource. It's important that the method itself be marked as `synchronized` or that a `synchronized` block is used here to guard against this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4356: NIFI-7576 ListenHTTP: Honor primary node only attribute
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4356:
URL: https://github.com/apache/nifi/pull/4356#issuecomment-648337836
Thanks for fixing this @Wastack ! All looks good to me. +1 merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #4356: NIFI-7576 ListenHTTP: Honor primary node only attribute
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #4356:
URL: https://github.com/apache/nifi/pull/4356#discussion_r444220971
##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListenHTTP.java
##########
@@ -373,6 +386,14 @@ public void createHttpServer(final ProcessContext context) throws Exception {
@Override
public void onTrigger(final ProcessContext context, final ProcessSessionFactory sessionFactory) {
+ try {
+ if (!initialized.get()) {
+ createHttpServerFromService(context);
+ }
+ } catch (Exception e) {
+ context.yield();
Review comment:
We should not swallow this exception without logging at least logging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 closed pull request #4356: NIFI-7576 ListenHTTP: Honor primary node only attribute
Posted by GitBox <gi...@apache.org>.
markap14 closed pull request #4356:
URL: https://github.com/apache/nifi/pull/4356
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org