[GitHub] [pulsar] merlimat commented on a change in pull request #4451: [Issue 4441][client]Deduce ClientConfigurationData.isUseTls from protocol

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4451: [Issue 4441][client]Deduce ClientConfigurationData.isUseTls from protocol
URL: https://github.com/apache/pulsar/pull/4451#discussion_r290549096
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigurationData.java
 ##########
 @@ -74,6 +74,16 @@
     private long defaultBackoffIntervalNanos = TimeUnit.MILLISECONDS.toNanos(100);
     private long maxBackoffIntervalNanos = TimeUnit.SECONDS.toNanos(30);
 
+    public boolean isUseTls() {
+        if (useTls)
+            return true;
+        if (this.getServiceUrl().startsWith("pulsar+ssl") || this.getServiceUrl().startsWith("https")) {
 
 Review comment:
   ```suggestion
           if (getServiceUrl() != null && (this.getServiceUrl().startsWith("pulsar+ssl") || this.getServiceUrl().startsWith("https"))) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services