You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Jesse Stockall <je...@yahoo.com> on 2002/09/06 02:48:42 UTC
VSS and SOS tasks refactoring
Hi
Now that Ant 1.5 is out the door, I'd like to submit some major
refactorings to the VSS and SOS tasks.
The refactorings get rid of some @todo's and get rid of tonnes of
duplicated code. I've also got testcases (improved for SOS, new for
VSS). I fixed a bunch of the Javadocs and also included the fix in
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10201
Hopefully these don't get lost, and one of the commiters can find some
time to have a look and commit them, if they are up to snuff.
I've throughly tested my changes with SOS and VSS and have been using
them at work for a couple months.
Thanks
Jesse
--
Jesse Stockall
jesse_dev@yahoo.com
Re: VSS and SOS tasks refactoring
Posted by Jesse Stockall <je...@cryptocard.com>.
On Fri, 2002-09-06 at 13:14, Erik Hatcher wrote:
> Not me, anymore. We've migrated to CVS at work! :))
If only we were so lucky :(
>
> I trust Jesse's patches, sight unseen.
The SOS testcases passed before and after, I added some extra tests to
it.
For VSS, before I got very far, I exposed enough that I could build some
testcases. The VSS tests caught quite a few bugs while I was doing the
refactoring, so I'm confidant that they should still behave as before.
Jesse
--
Jesse Stockall
jesse@cryptocard.com
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: VSS and SOS tasks refactoring
Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
Not me, anymore. We've migrated to CVS at work! :))
I trust Jesse's patches, sight unseen.
Perhaps we could post a note to ant-user saying "if you use VSS/SoS
please note big refactorings are now in, try them to ensure the next
release doesn't break you".
Steve Loughran wrote:
> Who has a setup to try these? Erik?
> Or shall I just commit them and trust Jesse; a few months use is a good
> metric.
> ----- Original Message -----
> From: "Jesse Stockall" <je...@yahoo.com>
> To: "Ant Developers List" <an...@jakarta.apache.org>
> Sent: Thursday, September 05, 2002 5:48 PM
> Subject: VSS and SOS tasks refactoring
>
>
>
>>Hi
>>
>>Now that Ant 1.5 is out the door, I'd like to submit some major
>>refactorings to the VSS and SOS tasks.
>>
>>The refactorings get rid of some @todo's and get rid of tonnes of
>>duplicated code. I've also got testcases (improved for SOS, new for
>>VSS). I fixed a bunch of the Javadocs and also included the fix in
>>http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10201
>>
>>Hopefully these don't get lost, and one of the commiters can find some
>>time to have a look and commit them, if they are up to snuff.
>>
>>I've throughly tested my changes with SOS and VSS and have been using
>>them at work for a couple months.
>>
>>Thanks
>>
>>Jesse
>>
>>--
>> Jesse Stockall
>> jesse_dev@yahoo.com
>>
>
>
>
> ----------------------------------------------------------------------------
> ----
>
>
>
>>--
>>To unsubscribe, e-mail: <ma...@jakarta.apache.org>
>>For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
>
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
>
>
>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: VSS and SOS tasks refactoring
Posted by Steve Loughran <st...@iseran.com>.
Who has a setup to try these? Erik?
Or shall I just commit them and trust Jesse; a few months use is a good
metric.
----- Original Message -----
From: "Jesse Stockall" <je...@yahoo.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Thursday, September 05, 2002 5:48 PM
Subject: VSS and SOS tasks refactoring
> Hi
>
> Now that Ant 1.5 is out the door, I'd like to submit some major
> refactorings to the VSS and SOS tasks.
>
> The refactorings get rid of some @todo's and get rid of tonnes of
> duplicated code. I've also got testcases (improved for SOS, new for
> VSS). I fixed a bunch of the Javadocs and also included the fix in
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10201
>
> Hopefully these don't get lost, and one of the commiters can find some
> time to have a look and commit them, if they are up to snuff.
>
> I've throughly tested my changes with SOS and VSS and have been using
> them at work for a couple months.
>
> Thanks
>
> Jesse
>
> --
> Jesse Stockall
> jesse_dev@yahoo.com
>
----------------------------------------------------------------------------
----
> --
> To unsubscribe, e-mail: <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>