You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2011/08/31 19:03:11 UTC
[jira] [Created] (HBASE-4313) Refactor TestHBaseFsck to make adding
individual hbck tests easier
Refactor TestHBaseFsck to make adding individual hbck tests easier
------------------------------------------------------------------
Key: HBASE-4313
URL: https://issues.apache.org/jira/browse/HBASE-4313
Project: HBase
Issue Type: Improvement
Affects Versions: 0.90.4
Reporter: Jonathan Hsieh
The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097237#comment-13097237 ]
jiraposter@reviews.apache.org commented on HBASE-4313:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1713/
-----------------------------------------------------------
(Updated 2011-09-05 18:41:02.929221)
Review request for hbase, Todd Lipcon and Michael Stack.
Changes
-------
Addressed nits and reordered tests so that clean test is first.
Summary
-------
This is a mostly semantics preserving patch. This will make HBASE-3354 easier to do. Trunk based version of patch to follow.
commit 6712c70b524bedf6a5e4999d4d2203373b0f1772
Author: Jonathan Hsieh <jo...@cloudera.com>
Date: Thu Aug 25 00:10:27 2011 -0700
HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
- Cleanup table creation
- Add proper MiniCluster shutdown
- Separate each corruption into a separate test
This addresses bug HBASE-4313.
https://issues.apache.org/jira/browse/HBASE-4313
Diffs (updated)
-----
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 1c766b3
Diff: https://reviews.apache.org/r/1713/diff
Testing
-------
tests pass.
Thanks,
jmhsieh
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097259#comment-13097259 ]
jiraposter@reviews.apache.org commented on HBASE-4313:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1713/#review1749
-----------------------------------------------------------
Ship it!
cool, sounds good. We need a trunk version as well before commit.
- Todd
On 2011-09-05 18:41:02, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1713/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-05 18:41:02)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a mostly semantics preserving patch. This will make HBASE-3354 easier to do. Trunk based version of patch to follow.
bq.
bq. commit 6712c70b524bedf6a5e4999d4d2203373b0f1772
bq. Author: Jonathan Hsieh <jo...@cloudera.com>
bq. Date: Thu Aug 25 00:10:27 2011 -0700
bq.
bq. HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
bq.
bq. - Cleanup table creation
bq. - Add proper MiniCluster shutdown
bq. - Separate each corruption into a separate test
bq.
bq.
bq. This addresses bug HBASE-4313.
bq. https://issues.apache.org/jira/browse/HBASE-4313
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 1c766b3
bq.
bq. Diff: https://reviews.apache.org/r/1713/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101104#comment-13101104 ]
Hudson commented on HBASE-4313:
-------------------------------
Integrated in HBase-TRUNK #2193 (See [https://builds.apache.org/job/HBase-TRUNK/2193/])
HBASE-4313 Refactor TestHBaseFsck to make adding individual hbck tests easier
stack :
Files :
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.5
>
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, hbase-4313-trunk.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097114#comment-13097114 ]
jiraposter@reviews.apache.org commented on HBASE-4313:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1713/
-----------------------------------------------------------
Review request for hbase, Todd Lipcon and Michael Stack.
Summary
-------
This is a mostly semantics preserving patch. This will make HBASE-3354 easier to do. Trunk based version of patch to follow.
commit 6712c70b524bedf6a5e4999d4d2203373b0f1772
Author: Jonathan Hsieh <jo...@cloudera.com>
Date: Thu Aug 25 00:10:27 2011 -0700
HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
- Cleanup table creation
- Add proper MiniCluster shutdown
- Separate each corruption into a separate test
This addresses bug HBASE-4313.
https://issues.apache.org/jira/browse/HBASE-4313
Diffs
-----
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 1c766b3
Diff: https://reviews.apache.org/r/1713/diff
Testing
-------
tests pass.
Thanks,
jmhsieh
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh reassigned HBASE-4313:
-------------------------------------
Assignee: Jonathan Hsieh
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-4313 started by Jonathan Hsieh.
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100160#comment-13100160 ]
jiraposter@reviews.apache.org commented on HBASE-4313:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1748/
-----------------------------------------------------------
Review request for hbase and Todd Lipcon.
Summary
-------
Trunk version of HBASE-4313.
commit 2d0e127fbe13be7d1fda0a7dff91c0717dbb13a0
Author: Jonathan Hsieh <jo...@cloudera.com>
Date: Thu Aug 25 00:10:27 2011 -0700
HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
- Cleanup table creation
- Add proper MiniCluster shutdown
- Separate each corruption into a separate test
This addresses bug HBASE-4313.
https://issues.apache.org/jira/browse/HBASE-4313
Diffs
-----
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 7ff8eb5
Diff: https://reviews.apache.org/r/1748/diff
Testing
-------
This unittest class passes.
Thanks,
jmhsieh
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, hbase-4313-trunk.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4313) Refactor TestHBaseFsck to make adding
individual hbck tests easier
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-4313:
----------------------------------
Status: Patch Available (was: In Progress)
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097233#comment-13097233 ]
jiraposter@reviews.apache.org commented on HBASE-4313:
------------------------------------------------------
bq. On 2011-09-05 17:53:41, Todd Lipcon wrote:
bq. > src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java, line 191
bq. > <https://reviews.apache.org/r/1713/diff/1/?file=37949#file37949line191>
bq. >
bq. > maybe name the tables after the tests?
done: tableDupStartKey, tableClean, tableOverlapStartKey, tableMetaHole
bq. On 2011-09-05 17:53:41, Todd Lipcon wrote:
bq. > src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java, line 204
bq. > <https://reviews.apache.org/r/1713/diff/1/?file=37949#file37949line204>
bq. >
bq. > what's this comment mean?
removed. This was broken when debugging the refactor.
bq. On 2011-09-05 17:53:41, Todd Lipcon wrote:
bq. > src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java, line 216
bq. > <https://reviews.apache.org/r/1713/diff/1/?file=37949#file37949line216>
bq. >
bq. > name this something like "NoErrors"? The test is that a clean table checks out OK
testHBaseFsckClean
bq. On 2011-09-05 17:53:41, Todd Lipcon wrote:
bq. > src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java, line 212
bq. > <https://reviews.apache.org/r/1713/diff/1/?file=37949#file37949line212>
bq. >
bq. > usually we put @Test after the javadoc
done
- jmhsieh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1713/#review1746
-----------------------------------------------------------
On 2011-09-05 10:28:15, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1713/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-05 10:28:15)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a mostly semantics preserving patch. This will make HBASE-3354 easier to do. Trunk based version of patch to follow.
bq.
bq. commit 6712c70b524bedf6a5e4999d4d2203373b0f1772
bq. Author: Jonathan Hsieh <jo...@cloudera.com>
bq. Date: Thu Aug 25 00:10:27 2011 -0700
bq.
bq. HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
bq.
bq. - Cleanup table creation
bq. - Add proper MiniCluster shutdown
bq. - Separate each corruption into a separate test
bq.
bq.
bq. This addresses bug HBASE-4313.
bq. https://issues.apache.org/jira/browse/HBASE-4313
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 1c766b3
bq.
bq. Diff: https://reviews.apache.org/r/1713/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4313) Refactor TestHBaseFsck to make adding
individual hbck tests easier
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-4313:
----------------------------------
Attachment: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
0.90 branch version.
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4313) Refactor TestHBaseFsck to make adding
individual hbck tests easier
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-4313:
----------------------------------
Attachment: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
Updated version addresses tlipcon's review comments.
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4313) Refactor TestHBaseFsck to make adding
individual hbck tests easier
Posted by "Jonathan Hsieh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Hsieh updated HBASE-4313:
----------------------------------
Attachment: hbase-4313-trunk.patch
Attached file that applies to trunk. Only ran the included test file. Test pass
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, hbase-4313-trunk.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4313) Refactor TestHBaseFsck to make adding
individual hbck tests easier
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4313:
-------------------------
Resolution: Fixed
Fix Version/s: 0.90.5
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed branch and trunk. Thanks for the patch Jon.
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 0.90.5
>
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, hbase-4313-trunk.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097224#comment-13097224 ]
jiraposter@reviews.apache.org commented on HBASE-4313:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1713/#review1746
-----------------------------------------------------------
Ship it!
just some nits, looks good
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
<https://reviews.apache.org/r/1713/#comment3972>
maybe name the tables after the tests?
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
<https://reviews.apache.org/r/1713/#comment3973>
what's this comment mean?
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
<https://reviews.apache.org/r/1713/#comment3974>
usually we put @Test after the javadoc
src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
<https://reviews.apache.org/r/1713/#comment3975>
name this something like "NoErrors"? The test is that a clean table checks out OK
- Todd
On 2011-09-05 10:28:15, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1713/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-05 10:28:15)
bq.
bq.
bq. Review request for hbase, Todd Lipcon and Michael Stack.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a mostly semantics preserving patch. This will make HBASE-3354 easier to do. Trunk based version of patch to follow.
bq.
bq. commit 6712c70b524bedf6a5e4999d4d2203373b0f1772
bq. Author: Jonathan Hsieh <jo...@cloudera.com>
bq. Date: Thu Aug 25 00:10:27 2011 -0700
bq.
bq. HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
bq.
bq. - Cleanup table creation
bq. - Add proper MiniCluster shutdown
bq. - Separate each corruption into a separate test
bq.
bq.
bq. This addresses bug HBASE-4313.
bq. https://issues.apache.org/jira/browse/HBASE-4313
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 1c766b3
bq.
bq. Diff: https://reviews.apache.org/r/1713/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4313) Refactor TestHBaseFsck to make
adding individual hbck tests easier
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100973#comment-13100973 ]
jiraposter@reviews.apache.org commented on HBASE-4313:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1748/#review1831
-----------------------------------------------------------
Ship it!
- Michael
On 2011-09-08 08:39:24, jmhsieh wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1748/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-08 08:39:24)
bq.
bq.
bq. Review request for hbase and Todd Lipcon.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Trunk version of HBASE-4313.
bq.
bq. commit 2d0e127fbe13be7d1fda0a7dff91c0717dbb13a0
bq. Author: Jonathan Hsieh <jo...@cloudera.com>
bq. Date: Thu Aug 25 00:10:27 2011 -0700
bq.
bq. HBASE-4313 Refactor TestHBaseFsck to make adding hbck tests easier
bq.
bq. - Cleanup table creation
bq. - Add proper MiniCluster shutdown
bq. - Separate each corruption into a separate test
bq.
bq.
bq. This addresses bug HBASE-4313.
bq. https://issues.apache.org/jira/browse/HBASE-4313
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 7ff8eb5
bq.
bq. Diff: https://reviews.apache.org/r/1748/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. This unittest class passes.
bq.
bq.
bq. Thanks,
bq.
bq. jmhsieh
bq.
bq.
> Refactor TestHBaseFsck to make adding individual hbck tests easier
> ------------------------------------------------------------------
>
> Key: HBASE-4313
> URL: https://issues.apache.org/jira/browse/HBASE-4313
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, 0001-HBASE-4313-Refactor-TestHBaseFsck-to-make-adding-hbc.patch, hbase-4313-trunk.patch
>
>
> The current TestHBaseFsck has one test case that tests multiple things in the same table. This refactor essentially preserves what is tested but isolates each error type so that there is no bleed over in error from table to table. This will also enable the writing of other simple to read tests for other hbck detectable errors.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira