You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/13 20:09:28 UTC
[GitHub] [netbeans] ses1112 opened a new pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory
ses1112 opened a new pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455
If you have multiple CustomIndexer with the same Mime-Type and your override the method "getPriority" in the corresponding IndexerFactory, this priority is ignored/never used.
So there is the bug, that sometimes it can be that this CustomIndexer are executed in the wrong order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455#issuecomment-763878548
@ses1112 block results from this:
> The changes can't be merged as is. PRs should be grouped by theme/area, which is not the case here. In addition we need to track contributions and record keeping is done in jira. Please create an issue on the netbeans jira (https://issues.apache.org/jira/secure/Dashboard.jspa) and reference the issue. It is referenced by fomatting the subject line of the commit as "[NETBEANS-XXXX] YYYY", where XXXX is the issue number and YYYY is the summary.
This is independed of a test. The changes themselves are fine, this is just a matter of getting the tracking right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ses1112 edited a comment on pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
ses1112 edited a comment on pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455#issuecomment-763855601
>
>
> Still marked as changes requested from @matthiasblaesing and needs the base branch changed to master if to be merged prior to freeze.
I don't have the knowledge to write a test. For the db-thing i can create a issue sson.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ses1112 closed pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
ses1112 closed pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ses1112 closed pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
ses1112 closed pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ses1112 commented on pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
ses1112 commented on pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455#issuecomment-763911726
Thanks for your help, i created two issues and two pull requests. For a better overview, i close this request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455#issuecomment-718218689
@ses1112 please address the requested changes by EOB tomorrow (PDT). Otherwise I have to move this PR out of the 12.2 release train.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ses1112 edited a comment on pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
ses1112 edited a comment on pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455#issuecomment-763855601
>
>
> Still marked as changes requested from @matthiasblaesing and needs the base branch changed to master if to be merged prior to freeze.
I don't have the knowledge to write a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ses1112 commented on pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
ses1112 commented on pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455#issuecomment-763855601
>
>
> Still marked as changes requested from @matthiasblaesing and needs the base branch changed to master if to be merged prior to freeze.
I don't have the knowledge to write a test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455#issuecomment-763784620
Still marked as changes requested from @matthiasblaesing and needs the base branch changed to master if to be merged prior to freeze.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ses1112 commented on pull request #2455: Fix: Multiple CustomIndexer with same Mime-Type use the priority of the IndexerFactory + Tooltip of columns in result-table
Posted by GitBox <gi...@apache.org>.
ses1112 commented on pull request #2455:
URL: https://github.com/apache/netbeans/pull/2455#issuecomment-763911726
Thanks for your help, i created two issues and two pull requests. For a better overview, i close this request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists