[jira] [Commented] (KAFKA-10434) Remove deprecated methods on WindowStore

["Matthias J. Sax (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-10434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17184776#comment-17184776 ] 

Matthias J. Sax commented on KAFKA-10434:
-----------------------------------------

We want to keep those methods as discussed on the KIP for perf reasons. Only for the "ReadOnly" stores that are used for IQ, we want to have the methods using `Instant` and `Duration` as they provide a better API. However, for the "read-write" interfaces we want to have the more performant `long` variants to avoid unnecessary (shorted lived) object creation.

Atm, we inherit the `long` variants from the read-only-interface. However, when we remove those methods from the read-only interface, we need to declare them on the "read-write" interface. The original PR did this "preparation" already by "re-declaring" the methods (that is kinda redundant atm, however allows us to mark the methods as "not deprecated" in the "read-write" classes). Hence, we don't mark those methods as `@Deprecated` as we don't intent to remove them, but we need to suppress the deprecation warning as long as we inherit the methods from the read-only interfaces.

I think we should close this ticket as "invalid". \cc [~ableegoldman]

> Remove deprecated methods on WindowStore
> ----------------------------------------
>
>                 Key: KAFKA-10434
>                 URL: https://issues.apache.org/jira/browse/KAFKA-10434
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Jorge Esteban Quilcate Otoya
>            Priority: Major
>
> From [https://github.com/apache/kafka/pull/9138#discussion_r474985997] and [https://github.com/apache/kafka/pull/9138#discussion_r474995606] :
> WindowStore contains ReadOnlyWindowStore methods.
> We could consider:
>  * Moving read methods from WindowStore to ReadOnlyWindowStore and/or
>  * Consider removing long based methods



--
This message was sent by Atlassian Jira
(v8.3.4#803005)