You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "AMOOOMA (via GitHub)" <gi...@apache.org> on 2026/02/06 00:47:10 UTC

[PR] Update queuing logic to avoid lock notify contention [beam]

AMOOOMA opened a new pull request, #37528:
URL: https://github.com/apache/beam/pull/37528

   Make sure we wake the next thread in line instead of notifying all and race to hope that the first item in queue wins.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/actions/workflows/build_wheels.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/actions/workflows/python_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/actions/workflows/java_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/actions/workflows/go_tests.yml/badge.svg?event=schedule&&?branch=master)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37528:
URL: https://github.com/apache/beam/pull/37528#issuecomment-3862477231

   > I see a few flakes related to #37528 but https://github.com/apache/beam/actions/runs/21734367880/job/62696049665?pr=37528 maybe looks concerning
   > 
   > ```
   > self = <apache_beam.ml.inference.model_manager_test.TestModelManager testMethod=test_single_model_convergence_with_fluctuations>
   > 
   >     def test_single_model_convergence_with_fluctuations(self):
   >       """
   >       Tests that the estimator converges to the true usage with fluctuations.
   >       """
   >       model_name = "fluctuating_model"
   >       model_cost = 3000.0
   >       load_cost = 2500.0
   >       # Fix random seed for reproducibility
   >       random.seed(42)
   >     
   >       def loader():
   >         self.mock_monitor.allocate(load_cost)
   >         return model_name
   >     
   >       model = self.manager.acquire_model(model_name, loader)
   >       self.manager.release_model(model_name, model)
   >       initial_est = self.manager._estimator.get_estimate(model_name)
   >       self.assertEqual(initial_est, load_cost)
   >     
   >       def run_inference():
   >         model = self.manager.acquire_model(model_name, loader)
   >         noise = model_cost - load_cost + random.uniform(-300.0, 300.0)
   >         self.mock_monitor.allocate(noise)
   >         time.sleep(0.1)
   >         self.mock_monitor.free(noise)
   >         self.manager.release_model(model_name, model)
   >         return
   >     
   >       with ThreadPoolExecutor(max_workers=8) as executor:
   >         futures = [executor.submit(run_inference) for _ in range(100)]
   >     
   >       for f in futures:
   >         f.result()
   >     
   >       est_cost = self.manager._estimator.get_estimate(model_name)
   > >     self.assertAlmostEqual(est_cost, model_cost, delta=100.0)
   > E     AssertionError: 2768.996662756712 != 3000.0 within 100.0 delta (231.00333724328812 difference)
   > ```
   > 
   > I don't _think_ this is caused by this PR, but any ideas on what might be causing this?
   
   Actually, I see it here as well https://github.com/apache/beam/pull/37506
   
   So it is probably unrelated, but may need follow up as well. Rerunning checks now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #37528:
URL: https://github.com/apache/beam/pull/37528#issuecomment-3857232424

   ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/37528?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `35 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 35.87%. Comparing base ([`4e218f0`](https://app.codecov.io/gh/apache/beam/commit/4e218f0183e5f0c69d98808a019b5f4940b24402?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`aee2900`](https://app.codecov.io/gh/apache/beam/commit/aee2900e1032f61c9076c788f7058dd1db7cb5f7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 9 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/beam/pull/37528?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...s/python/apache\_beam/ml/inference/model\_manager.py](https://app.codecov.io/gh/apache/beam/pull/37528?src=pr&el=tree&filepath=sdks%2Fpython%2Fapache_beam%2Fml%2Finference%2Fmodel_manager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vbWwvaW5mZXJlbmNlL21vZGVsX21hbmFnZXIucHk=) | 0.00% | [35 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/37528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #37528      +/-   ##
   ============================================
   - Coverage     35.87%   35.87%   -0.01%     
     Complexity     1676     1676              
   ============================================
     Files          1063     1063              
     Lines        166481   166580      +99     
     Branches       1208     1208              
   ============================================
   + Hits          59722    59756      +34     
   - Misses       104578   104643      +65     
     Partials       2181     2181              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/beam/pull/37528/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [python](https://app.codecov.io/gh/apache/beam/pull/37528/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.68% <0.00%> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/37528?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #37528:
URL: https://github.com/apache/beam/pull/37528#discussion_r2775954349


##########
sdks/python/apache_beam/ml/inference/model_manager.py:
##########
@@ -508,19 +538,17 @@ def acquire_model(self, tag: str, loader_func: Callable[[], Any]) -> Any:
 
       finally:
         # Remove self from wait queue once done
-        if self._wait_queue and self._wait_queue[0][2] is my_id:
+        if self._wait_queue and self._wait_queue[0].ticket_num == ticket_num:
           heapq.heappop(self._wait_queue)
         else:
           logger.warning(
               "Item not at head of wait queue during cleanup"
               ", this is not expected: tag=%s ticket num=%s",
               tag,
               ticket_num)

Review Comment:
   I _think_ maybe this could happen now if a ticket changes priority, but not sure



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37528:
URL: https://github.com/apache/beam/pull/37528#issuecomment-3857675476

   Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #37528:
URL: https://github.com/apache/beam/pull/37528#discussion_r2775892888


##########
sdks/python/apache_beam/ml/inference/model_manager.py:
##########
@@ -508,19 +538,17 @@ def acquire_model(self, tag: str, loader_func: Callable[[], Any]) -> Any:
 
       finally:
         # Remove self from wait queue once done
-        if self._wait_queue and self._wait_queue[0][2] is my_id:
+        if self._wait_queue and self._wait_queue[0].ticket_num == ticket_num:
           heapq.heappop(self._wait_queue)
         else:
           logger.warning(
               "Item not at head of wait queue during cleanup"
               ", this is not expected: tag=%s ticket num=%s",
               tag,
               ticket_num)

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   The warning message 'Item not at head of wait queue during cleanup, this is not expected' might be misleading now that the `_cancelled_tickets` mechanism is in place. If a ticket is not at the head, it is now explicitly marked as cancelled, which is an expected behavior for tickets that are no longer needed but haven't reached the head of the queue yet. This warning could imply an error state when it's actually a handled scenario. Consider rephrasing or removing this warning if it no longer indicates an unexpected condition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37528:
URL: https://github.com/apache/beam/pull/37528#issuecomment-3861715719

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #37528:
URL: https://github.com/apache/beam/pull/37528


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "AMOOOMA (via GitHub)" <gi...@apache.org>.
AMOOOMA commented on PR #37528:
URL: https://github.com/apache/beam/pull/37528#issuecomment-3861709621

   R: @damccorm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "AMOOOMA (via GitHub)" <gi...@apache.org>.
AMOOOMA commented on code in PR #37528:
URL: https://github.com/apache/beam/pull/37528#discussion_r2776020195


##########
sdks/python/apache_beam/ml/inference/model_manager.py:
##########
@@ -508,19 +538,17 @@ def acquire_model(self, tag: str, loader_func: Callable[[], Any]) -> Any:
 
       finally:
         # Remove self from wait queue once done
-        if self._wait_queue and self._wait_queue[0][2] is my_id:
+        if self._wait_queue and self._wait_queue[0].ticket_num == ticket_num:
           heapq.heappop(self._wait_queue)
         else:
           logger.warning(
               "Item not at head of wait queue during cleanup"
               ", this is not expected: tag=%s ticket num=%s",
               tag,
               ticket_num)

Review Comment:
   Yeah it could happen still if the ticket timed out, I will remove this warning check though since it doesn't really help much and needs to grab the logging lock for timeout which is not great.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37528:
URL: https://github.com/apache/beam/pull/37528#issuecomment-3862424790

   I see a few flakes related to https://github.com/apache/beam/pull/37528 but https://github.com/apache/beam/actions/runs/21734367880/job/62696049665?pr=37528 maybe looks concerning
   
   ```
   self = <apache_beam.ml.inference.model_manager_test.TestModelManager testMethod=test_single_model_convergence_with_fluctuations>
   
       def test_single_model_convergence_with_fluctuations(self):
         """
         Tests that the estimator converges to the true usage with fluctuations.
         """
         model_name = "fluctuating_model"
         model_cost = 3000.0
         load_cost = 2500.0
         # Fix random seed for reproducibility
         random.seed(42)
       
         def loader():
           self.mock_monitor.allocate(load_cost)
           return model_name
       
         model = self.manager.acquire_model(model_name, loader)
         self.manager.release_model(model_name, model)
         initial_est = self.manager._estimator.get_estimate(model_name)
         self.assertEqual(initial_est, load_cost)
       
         def run_inference():
           model = self.manager.acquire_model(model_name, loader)
           noise = model_cost - load_cost + random.uniform(-300.0, 300.0)
           self.mock_monitor.allocate(noise)
           time.sleep(0.1)
           self.mock_monitor.free(noise)
           self.manager.release_model(model_name, model)
           return
       
         with ThreadPoolExecutor(max_workers=8) as executor:
           futures = [executor.submit(run_inference) for _ in range(100)]
       
         for f in futures:
           f.result()
       
         est_cost = self.manager._estimator.get_estimate(model_name)
   >     self.assertAlmostEqual(est_cost, model_cost, delta=100.0)
   E     AssertionError: 2768.996662756712 != 3000.0 within 100.0 delta (231.00333724328812 difference)
   ```
   
   I don't _think_ this is caused by this PR, but any ideas on what might be causing this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #37528:
URL: https://github.com/apache/beam/pull/37528#issuecomment-3862412511

   /gemini review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update queuing logic to avoid lock notify contention [beam]

Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37528:
URL: https://github.com/apache/beam/pull/37528#issuecomment-3857171292

   ## Summary of Changes
   
   Hello @AMOOOMA, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
   
   This pull request refactors the queuing and synchronization logic within the `ModelManager` to mitigate lock contention, particularly when many threads are waiting to acquire a model. By transitioning from a broadcast-based notification system (`notify_all`) to a more precise, ticket-based approach that wakes only the next eligible thread, the changes aim to improve the fairness and efficiency of resource acquisition, especially under high load.
   
   ### Highlights
   
   * **Targeted Thread Notification**: Replaced `threading.Condition.notify_all()` with a mechanism to wake only the next thread in the queue, reducing contention and improving fairness.
   * **QueueTicket Introduction**: Introduced a `QueueTicket` class to encapsulate priority, ticket number, tag, and a dedicated `threading.Event` for individual thread waking, enabling more precise control over thread notifications.
   * **Efficient Cancellation Handling**: Added a `_cancelled_tickets` set and logic to efficiently remove cancelled requests from the head of the wait queue without requiring a full heap re-heapify operation.
   * **Refactored Waiting Logic**: Implemented `_wake_next_in_queue` and `_wait_in_queue` helper methods to streamline the queuing and notification process within the `acquire_model` method.
   * **Enhanced Timeout Test**: Updated the `test_model_manager_timeout` to simulate higher concurrency (1000 threads) and added a post-timeout check to verify the `ModelManager` remains functional after a timeout scenario.
   
   🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
   
   <details>
   <summary><b>Changelog</b></summary>
   
   * **sdks/python/apache_beam/ml/inference/model_manager.py**
       * Introduced `QueueTicket` class with `priority`, `ticket_num`, `tag`, and `wake_event` attributes, and a custom `__lt__` method for heap ordering.
       * Added `_cancelled_tickets` set to `ModelManager` to track tickets that have been cancelled.
       * Implemented `_wake_next_in_queue` method to notify the next valid ticket in the priority queue.
       * Implemented `_wait_in_queue` method to allow a specific ticket to wait on its `wake_event`.
       * Modified `acquire_model` to create and use `QueueTicket` objects instead of raw tuples.
       * Replaced `self._cv.wait()` with `self._wait_in_queue(my_ticket)` for waiting threads.
       * Replaced `self._cv.notify_all()` with `self._wake_next_in_queue()` in relevant sections, including model release and priority re-evaluation.
       * Updated `_evict_to_make_space` to access the `tag` attribute directly from `QueueTicket` objects.
       * Improved cleanup logic in `acquire_model`'s `finally` block to mark cancelled tickets instead of searching and re-heapifying.
   * **sdks/python/apache_beam/ml/inference/model_manager_test.py**
       * Expanded `test_model_manager_timeout` to submit 1000 `acquire_model` calls concurrently.
       * Added a post-timeout check to ensure the `ModelManager` can still acquire and release models, verifying its continued functionality.
   </details>
   
   
   
   <details>
   <summary><b>Activity</b></summary>
   
   * The pull request includes a standard contribution checklist.
   * CI build statuses for Python, Java, and Go tests are displayed.
   * No human comments or reviews have been recorded yet.
   </details>
   
   
   <details>
   <summary><b>Using Gemini Code Assist</b></summary>
   <br>
   
   The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
   
   <b>Invoking Gemini</b>
   
   You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   <b>Customization</b>
   
   To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   <b>Limitations & Feedback</b>
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   
   <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
   </details>
   
   
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org