You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/05/13 17:37:20 UTC
Review Request 21382: Improve handling of groupmod errors and provide
ability to skip
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21382/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-5748
https://issues.apache.org/jira/browse/AMBARI-5748
Repository: ambari
Description
-------
Found this on customer deployment. LDAP group exists for nagios.
#] getent group nagios
nagios:*:nagios
Deploy fails with error **"groupmod nagios" not present in /etc/group**
1) Provide an Misc > Advanced option during install giving people the option
to skip group modifications (basically, don't call groupmod)
[ ] Skip group modifications during install
2) Make sure the error when groupmod fails is clear in the Ambari logs (and
Ambari Web UI) so that folks know groupmod failed, and that a way to get
around this is to check the option in Misc > Advanced to skip groupmod.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py 7c5ac6e
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py c588ffc
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml ca94d38
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py eeb21e8
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 9ac5667
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml 956b155
ambari-server/src/test/python/stacks/1.3.2/configs/default.json 078f533
ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 6c922cf
ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py f68da7b
ambari-server/src/test/python/stacks/2.0.6/configs/default.json dc61567
ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 82b9855
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py e70debb
ambari-web/app/data/HDP2/global_properties.js 5f6cb5a
ambari-web/app/data/global_properties.js 86507c0
Diff: https://reviews.apache.org/r/21382/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 21382: Improve handling of groupmod errors and provide
ability to skip
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21382/#review42829
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On May 13, 2014, 3:39 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21382/
> -----------------------------------------------------------
>
> (Updated May 13, 2014, 3:39 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5748
> https://issues.apache.org/jira/browse/AMBARI-5748
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Found this on customer deployment. LDAP group exists for nagios.
>
>
>
>
> #] getent group nagios
> nagios:*:nagios
>
>
> Deploy fails with error **"groupmod nagios" not present in /etc/group**
>
> 1) Provide an Misc > Advanced option during install giving people the option
> to skip group modifications (basically, don't call groupmod)
>
> [ ] Skip group modifications during install
>
> 2) Make sure the error when groupmod fails is clear in the Ambari logs (and
> Ambari Web UI) so that folks know groupmod failed, and that a way to get
> around this is to check the option in Misc > Advanced to skip groupmod.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py 7c5ac6e
> ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py c588ffc
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml ca94d38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py eeb21e8
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 9ac5667
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml 956b155
> ambari-server/src/test/python/stacks/1.3.2/configs/default.json 078f533
> ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 6c922cf
> ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py f68da7b
> ambari-server/src/test/python/stacks/2.0.6/configs/default.json dc61567
> ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 82b9855
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py e70debb
> ambari-web/app/data/HDP2/global_properties.js 5f6cb5a
> ambari-web/app/data/global_properties.js 86507c0
>
> Diff: https://reviews.apache.org/r/21382/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 21382: Improve handling of groupmod errors and provide
ability to skip
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21382/
-----------------------------------------------------------
(Updated May 13, 2014, 3:39 p.m.)
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-5748
https://issues.apache.org/jira/browse/AMBARI-5748
Repository: ambari
Description
-------
Found this on customer deployment. LDAP group exists for nagios.
#] getent group nagios
nagios:*:nagios
Deploy fails with error **"groupmod nagios" not present in /etc/group**
1) Provide an Misc > Advanced option during install giving people the option
to skip group modifications (basically, don't call groupmod)
[ ] Skip group modifications during install
2) Make sure the error when groupmod fails is clear in the Ambari logs (and
Ambari Web UI) so that folks know groupmod failed, and that a way to get
around this is to check the option in Misc > Advanced to skip groupmod.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/params.py 7c5ac6e
ambari-server/src/main/resources/stacks/HDP/1.3.2/hooks/before-INSTALL/scripts/shared_initialization.py c588ffc
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml ca94d38
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/params.py eeb21e8
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py 9ac5667
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml 956b155
ambari-server/src/test/python/stacks/1.3.2/configs/default.json 078f533
ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 6c922cf
ambari-server/src/test/python/stacks/1.3.2/hooks/before-INSTALL/test_before_install.py f68da7b
ambari-server/src/test/python/stacks/2.0.6/configs/default.json dc61567
ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 82b9855
ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py e70debb
ambari-web/app/data/HDP2/global_properties.js 5f6cb5a
ambari-web/app/data/global_properties.js 86507c0
Diff: https://reviews.apache.org/r/21382/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk