[jira] Commented: (HBASE-1596) Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher.

["Jonathan Gray (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727012#action_12727012 ] 

Jonathan Gray commented on HBASE-1596:
--------------------------------------

Patch looks fine to me.

When do we need to do something for this?

{noformat}
+  public void process(WatchedEvent event) {
+    // TODO: Write me to handle session expired events.
+  }
{noformat}

> Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher.
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-1596
>                 URL: https://issues.apache.org/jira/browse/HBASE-1596
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Nitay Joffe
>            Assignee: Nitay Joffe
>             Fix For: 0.20.0
>
>         Attachments: hbase-1596.patch
>
>
> We originally wrote a WatcherWrapper for our ZooKeeperWrapper which cuts through some of the ZooKeeper interface so that we wouldn't have to supply Watchers everywhere. Now that we're having to deal with things like Session Expired all over the place, this class should no longer be used.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.