You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/09 15:58:43 UTC

[GitHub] [spark] srowen commented on a change in pull request #24024: [core]spark.diskStore.subDirectories > 0 should throw Exception

srowen commented on a change in pull request #24024: [core]spark.diskStore.subDirectories > 0 should throw Exception
URL: https://github.com/apache/spark/pull/24024#discussion_r264004312
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
 ##########
 @@ -301,6 +301,8 @@ package object config {
       .doc("Number of subdirectories inside each path listed in spark.local.dir for " +
         "hashing Block files into.")
       .intConf
+      .checkValue(_ > 0, "The number of subdirectories for put hashing Block files into " +
 
 Review comment:
   I'd put the key string in the error message, and just say "must be positive".
   The title needs to be fixed here; it's the wrong way around. Add `[MINOR]` to the front. @lcqzte10192193 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org