You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/24 13:22:19 UTC
[GitHub] [skywalking-banyandb] hanahmily opened a new pull request #52: Add more functions to support test
hanahmily opened a new pull request #52:
URL: https://github.com/apache/skywalking-banyandb/pull/52
These changes introduce some functions to support query module testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #52: Add more functions to support test
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #52:
URL: https://github.com/apache/skywalking-banyandb/pull/52#issuecomment-926623248
@liuhaoyang Please take a look, do these changes support your need?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #52: Add more functions to support test
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #52:
URL: https://github.com/apache/skywalking-banyandb/pull/52#discussion_r715612594
##########
File path: banyand/stream/stream_query.go
##########
@@ -39,8 +41,12 @@ type Query interface {
}
type Stream interface {
+ io.Closer
+ Write(value *streamv2.ElementValue) error
Review comment:
From your PR's CI failures, the stream tests are flaky. This new write function can fix this defect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on a change in pull request #52: Add more functions to support test
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #52:
URL: https://github.com/apache/skywalking-banyandb/pull/52#discussion_r715609688
##########
File path: banyand/stream/stream_query.go
##########
@@ -39,8 +41,12 @@ type Query interface {
}
type Stream interface {
+ io.Closer
+ Write(value *streamv2.ElementValue) error
Review comment:
Once the write returns an empty error, indices and raw data are all there. @lujiajing1126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] lujiajing1126 commented on pull request #52: Add more functions to support test
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #52:
URL: https://github.com/apache/skywalking-banyandb/pull/52#issuecomment-926654473
https://github.com/apache/skywalking-banyandb/blob/main/banyand/stream/service.go#L103
Seems issue with this line. I guess we have to setup `writeListener` after this loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily commented on pull request #52: Add more functions to support test
Posted by GitBox <gi...@apache.org>.
hanahmily commented on pull request #52:
URL: https://github.com/apache/skywalking-banyandb/pull/52#issuecomment-926689758
> https://github.com/apache/skywalking-banyandb/blob/main/banyand/stream/service.go#L103
>
> Seems issue with this line. I guess we have to setup `writeListener` after this loop?
Prune it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #52: Add more functions to support test
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #52:
URL: https://github.com/apache/skywalking-banyandb/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org